Lazily raise exceptions for missing data #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 7, 2012 20:46
This was passing because of a typo in the lambda. By specifying the exception explicitly we ensure errors in test code don't mask errors in the production code.
Previously a guard against missing files prevented you from using this library even if your app doesn't require the missing data. This patch changes the behavior to lazily raise exceptions only when accessing missing data. The motivation here is to make it easier to work with data as provided by transit centers. Although google's spec lists `calendar.txt` as a required file, MTA does not include it with their LIRR data (http://bit.ly/WETHPD). Instead they manage everything through `calendar_dates.txt`. This patch allows us to make use of the data as provided even if it doesn't conform to spec.
nerdEd
added a commit
that referenced
this pull request
Nov 27, 2012
Lazily raise exceptions for missing data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted this so that I could work with data from NJ Transit without having to add empty missing source files. Commit has more details.
Cheers!