Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to contact you #6

Open
linuxgurugamer opened this issue Jul 2, 2020 · 1 comment
Open

Need to contact you #6

linuxgurugamer opened this issue Jul 2, 2020 · 1 comment

Comments

@linuxgurugamer
Copy link
Contributor

Hi Nereid,

Hope this finds you well.

I've been working on a bunch of enhancements to the mod as well as converting it from using threads to using coroutines (you can see my bug report on the forum and on github (I think)), the conversion due to the mod crashing my game(s) repeatedly back in May.

@Lisias feels that threads are still the way to go, I disagree with him, but it's a friendly disagreement. He is going to (according to his last post) make some changes to fix the bug and submit a PR.

These are a full list of the changes I did:

  • Replaced all threading code with CoRoutines
  • Removed asynchronous setting
  • Added SaveOnLaunch, with template string
  • Rewrite config saves to standard ConfigNode format
  • Added SaveConfirmationSound option
  • Added QuickSave ability, with template string
  • Added expiration limits to quicksaves
  • Added tabs to configuration page to select between Backup Options, Quicksave Options and Sound Options
  • Adjusted height of the Status and Clone pages to no more than 1/2 of the window height
  • I had assumed that you were not around since you haven't been on the forums for about 6 months.

If you are indeed leaving, I'd be happy to adopt the mod, otherwise if you are going to make a release with @Lisias's changes, I'll step back. I'm a bit torn between forking the mod with all my changes or not.

I'll wait to hear from you as to your intentions. I try to be a cooperative modder, so if you continue, then I'll just pull my stuff out into a stand-alone mod.

Let me know, thanks

Linuxgurugamer

@Nereid42
Copy link
Owner

Nereid42 commented Jul 2, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants