-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to contact you #6
Comments
Hi!
I'm not leaving, but my company is developing a new product and we are in a critical stage at the moment - and corona doesn't makes it easier those days...
Ths week I'm on holyday but I don't have enought time to update any mods. I have compiled and tested them against 1.9.1 and all seems to work fine. But I didn't change anything so far.
Give me a one or two weeks.
Regrads
André
Gesendet: Donnerstag, 02. Juli 2020 um 05:16 Uhr
Von: "linuxgurugamer" <notifications@github.com>
An: "Nereid42/S.A.V.E" <S.A.V.E@noreply.github.com>
Cc: "Subscribed" <subscribed@noreply.github.com>
Betreff: [Nereid42/S.A.V.E] Need to contact you (#6)
Hi Nereid,
Hope this finds you well.
I've been working on a bunch of enhancements to the mod as well as converting it from using threads to using coroutines (you can see my bug report on the forum and on github (I think)), the conversion due to the mod crashing my game(s) repeatedly back in May.
@Lisias feels that threads are still the way to go, I disagree with him, but it's a friendly disagreement. He is going to (according to his last post) make some changes to fix the bug and submit a PR.
These are a full list of the changes I did:
Replaced all threading code with CoRoutines
Removed asynchronous setting
Added SaveOnLaunch, with template string
Rewrite config saves to standard ConfigNode format
Added SaveConfirmationSound option
Added QuickSave ability, with template string
Added expiration limits to quicksaves
Added tabs to configuration page to select between Backup Options, Quicksave Options and Sound Options
Adjusted height of the Status and Clone pages to no more than 1/2 of the window height
I had assumed that you were not around since you haven't been on the forums for about 6 months.
If you are indeed leaving, I'd be happy to adopt the mod, otherwise if you are going to make a release with @Lisias's changes, I'll step back. I'm a bit torn between forking the mod with all my changes or not.
I'll wait to hear from you as to your intentions. I try to be a cooperative modder, so if you continue, then I'll just pull my stuff out into a stand-alone mod.
Let me know, thanks
Linuxgurugamer
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi Nereid,
Hope this finds you well.
I've been working on a bunch of enhancements to the mod as well as converting it from using threads to using coroutines (you can see my bug report on the forum and on github (I think)), the conversion due to the mod crashing my game(s) repeatedly back in May.
@Lisias feels that threads are still the way to go, I disagree with him, but it's a friendly disagreement. He is going to (according to his last post) make some changes to fix the bug and submit a PR.
These are a full list of the changes I did:
If you are indeed leaving, I'd be happy to adopt the mod, otherwise if you are going to make a release with @Lisias's changes, I'll step back. I'm a bit torn between forking the mod with all my changes or not.
I'll wait to hear from you as to your intentions. I try to be a cooperative modder, so if you continue, then I'll just pull my stuff out into a stand-alone mod.
Let me know, thanks
Linuxgurugamer
The text was updated successfully, but these errors were encountered: