Add option for model normals on ply export #1965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CameronFraser
force-pushed
the
add-option-for-model-normals-on-ply-export
branch
from
e7a3cc8
to
4f43918
Compare
tancik
reviewed
May 25, 2023
|
LGTM. Can you merge |
…on mesh export wrt normals + hoist validate pipeline up so both exporters can use it
CameronFraser
force-pushed
the
add-option-for-model-normals-on-ply-export
branch
from
56b6cdb
to
a5e97e9
Compare
|
@ethanweber updated branch with main |
ethanweber
approved these changes
May 30, 2023
|
worth noting that in my case when using nerfstudio with aerial imagery the nerfacto predicted normals and the resulting mesh were significantly better looking than using open3d for estimating normals |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the arguments related to normals for point cloud export consistent with the arguments related to normals for Poisson export. Doing this adds support for the use case where a user may want to export just a point cloud with predicted normals instead of o3d estimated normals to use in their own Poisson meshing pipeline.
Additionally, the viewer is updated to reflect the changes.