Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to fall back to torch if tcnn not found #2124

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Conversation

ethanweber
Copy link
Collaborator

@ethanweber ethanweber commented Jun 23, 2023

self.build_nn_modules() was not present where it should be, so this adds it back. The logic is to fall back to torch implementation if tcnn is specified but not installed/found.

Copy link
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@tancik tancik merged commit d9ee575 into main Jun 27, 2023
4 checks passed
@tancik tancik deleted the ethan/fix_tcnn_fallback branch June 27, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants