Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visibility Field from Nerfbusters #2264

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Visibility Field from Nerfbusters #2264

wants to merge 6 commits into from

Conversation

ethanweber
Copy link
Collaborator

@ethanweber ethanweber commented Jul 25, 2023 •
edited

  • Adds VisibilityField
  • Adds visibility loss to pipeline

@Ilyabasharov
Copy link
Contributor

Ilyabasharov commented Jul 26, 2023 •
edited

@ethanweber I think now VisibilityField class name is too common. There are many papers that using VisibilityField too, so it would be better to distinguish them in this framework

@selitvin selitvin mentioned this pull request Jul 26, 2023
Closed
@ethanweber
Copy link
Collaborator Author

@ethanweber I think now VisibilityField class name is too common. There are many papers that using VisibilityField too, so it would be better to distinguish them in this framework

Oh interesting, thanks for the heads up. Can you point me to some papers that have the same name?

@Ilyabasharov
Copy link
Contributor

@ethanweber I think now VisibilityField class name is too common. There are many papers that using VisibilityField too, so it would be better to distinguish them in this framework

Oh interesting, thanks for the heads up. Can you point me to some papers that have the same name?

Block-NeRF paper

@ethanweber
Copy link
Collaborator Author

Hey @tancik, do you have thoughts on how the visibility loss should be added wrt. the vanilla pipeline? Do you think it should be its own pipeline?

@ethanweber ethanweber requested a review from tancik August 19, 2023 19:49
@jaggzh jaggzh mentioned this pull request Nov 26, 2023
Closed
@ethanweber ethanweber mentioned this pull request Apr 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrederikWarburg FrederikWarburg FrederikWarburg left review comments

@tancik tancik Awaiting requested review from tancik

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ethanweber @Ilyabasharov @FrederikWarburg