Update pixel_samplers.py #2327
Merged
Update pixel_samplers.py #2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now uses the specified batch_size param in sample_method()
pwais
reviewed
Aug 10, 2023
| @@ -392,7 +392,7 @@ def __init__(self, config: PairPixelSamplerConfig, **kwargs) -> None: | |||
| # overrides base method | |||
| def sample_method( # pylint: disable=no-self-use | |||
| self, | |||
| batch_size: int, | |||
| batch_size: Optional[int], | |||
There was a problem hiding this comment.
tanku for this fix!
is this param really optional tho? in the superclass it is not optional. it's a little confusing because the pixel sampler seems to have a side API for configuring batch size even tho notionally the batch size config can be passed in via a different flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now uses the specified batch_size param in sample_method(), fixes the pointcloud exporting error in #2313