Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_train tmp_path #2400

Merged
merged 2 commits into from
Sep 7, 2023
Merged

test_train tmp_path #2400

merged 2 commits into from
Sep 7, 2023

Conversation

drewgilliam
Copy link
Contributor

@drewgilliam drewgilliam commented Sep 6, 2023 •
edited

Use tmp_path pytest fixture during test_train to direct the config output_dir to temporary pytest subdirectory. Also call to config.set_timestamp() to set timestamp on config training directory.

brentyi
brentyi reviewed Sep 7, 2023
View reviewed changes
Copy link
Collaborator

@brentyi brentyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks overall reasonable to me!

pyproject.toml Outdated Show resolved Hide resolved
tests/test_train.py Outdated Show resolved Hide resolved
@drewgilliam drewgilliam changed the title typeguard & tmp_path test_train tmp_path Sep 7, 2023
@brentyi brentyi enabled auto-merge (squash) September 7, 2023 18:07
@brentyi brentyi merged commit d947aee into nerfstudio-project:main Sep 7, 2023
4 checks passed
@drewgilliam drewgilliam deleted the cicd branch September 7, 2023 18:19
maturk pushed a commit that referenced this pull request Sep 11, 2023
@drewgilliam @maturk
Specify path for test outputs (#2400)
e210fd7 
* test_train - set_timestamp, output_dir in pytest tmp_path

* test_train typehints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentyi brentyi brentyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drewgilliam @brentyi