make refine intrinsics during ns-process-data optional #2550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ns-process-data will still refine intrinsics by default for compatibility. Specify --no-refine-intrinsics to turn off.
|
Motivation: at least at present, there seems to be significant improvement using non-refined versions of some datasets with #2521. |
machenmusik
added a commit
to machenmusik/nerfstudio
that referenced
this pull request
Oct 24, 2023
…oject#2550) ns-process-data will still refine intrinsics by default for compatibility. Specify --no-refine-intrinsics to turn off.
kerrj
pushed a commit
that referenced
this pull request
Oct 24, 2023
* make refine intrinsics during ns-process-data optional (#2550) ns-process-data will still refine intrinsics by default for compatibility. Specify --no-refine-intrinsics to turn off. * multinerf uses equals sign
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ns-process-data will still refine intrinsics by default for compatibility.
Specify --no-refine-intrinsics to turn off.