Ply dataparser #2557
Merged
Ply dataparser #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, this is useful. I think we can merge the dataparser with its own PR, and then a separate PR should add code to ns-process-data to generate a PLY from colmap when it finishes. |
|
I think this is useful enough to merge into main, since it includes generally loading .ply files in the dataparser and also metric export option |
|
Need to pull out just the relevant changes though, changing the base branch includes all of splatting too |
Open
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IN PROGRESS do not merge yet
Loads a ply file as initial point cloud if specified
Specify
transforms.jsonwith "ply_file_path" in header, i.e{
"camera_model": "OPENCV",
"cx": 320,
"cy": 240,
"w": 640,
"h": 480,
"ply_file_path": "smith.ply",
...