Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask flexibility for methods than need to sample in the masked region #2647

Merged
merged 8 commits into from
Jan 29, 2024

Conversation

ethanweber
Copy link
Collaborator

I'm making minor changes to make the masking feature more flexible. I have a method where I want to sample everywhere in the image, including the masked out regions, as specified in the transforms.json file. My custom model will compute losses differently depending on where it is masked out.

Furthermore, I sometimes want to give the masked out region a specific color. A minor modification to the dataloading and dataset enables this.

Lastly, I expose the trainer to the callback because my pipeline needs access to this, specifically to read off the base_dir so I can avoid wandb.

@ethanweber ethanweber requested a review from kerrj December 4, 2023 20:19
@ethanweber ethanweber changed the title Mask Flexibility for New Method Mask flexibility for methods than need to sample in the masked region Jan 24, 2024
@ethanweber ethanweber requested review from kerrj and removed request for brentyi and kerrj January 25, 2024 02:18
Copy link
Collaborator

@kerrj kerrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@ethanweber ethanweber merged commit c397588 into main Jan 29, 2024
2 checks passed
@ethanweber ethanweber deleted the ethan/mask_flexibility branch January 29, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants