Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for loading 3D points with ODM data processor #2838

Merged
merged 4 commits into from
Jan 28, 2024

Conversation

pierotofy
Copy link
Contributor

@pierotofy pierotofy commented Jan 27, 2024

Hello 馃憢

this PR adds support for loading 3D points (useful for running splatfacto) from datasets imported from ODM.

Hope this can be useful to others.

@kerrj
Copy link
Collaborator

kerrj commented Jan 27, 2024

Thanks for the PR! to run linting see here, ns-dev-test will fix the format errors.

I don't have any ODM datasets but do you have any screenshots/renders you could share here?

@pierotofy
Copy link
Contributor Author

pierotofy commented Jan 27, 2024

Thanks for the quick review, sorry about the linting!

  • Made some changes to make sure the points are in the proper coordinate system (they weren't)
  • Ran ruff
  • Screenshot of a dataset (brighton beach) I've just processed:

image

Link to original images: https://github.com/pierotofy/drone_dataset_brighton_beach
Link to nerfstudio data exported with this PR from ODM: https://drive.google.com/file/d/1A8dUyR8_Nroz-4F8FsFDcTlo_0TCIz-4/view?usp=sharing

Copy link
Collaborator

@kerrj kerrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@kerrj kerrj merged commit fb1fee1 into nerfstudio-project:main Jan 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants