Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ODM data processor coordinate system #2847

Merged
merged 7 commits into from
Feb 1, 2024

Conversation

pierotofy
Copy link
Contributor

Hello 馃憢

I made a mistake in #2838 and while processing a different dataset I noticed an issue with the coordinate system conversion I wrote.

I tested these changes with multiple datasets and they work now.

image

image

Link to datasets exported with proposed change: https://drive.google.com/drive/folders/1tmeBSlLcUJKxpwqhFC2YqqSGUKlGoMtN?usp=sharing

@ichsan2895
Copy link

ichsan2895 commented Jan 29, 2024

Hello @pierotofy , I want to ask, why ns-process-data odm makes the images in OUTPUT/images folder has smaller size than original images? But the resolution is remain same.

For example, ns-process-data odm --data ODM_RESULT --output-dir NERFSTUDIO_ODM

Then I compare the images in ODM_RESULT/images vs NERFSTUDIO_ODM/images. It was different but the resolution is same.

Is that case intended?
Is that case reduce the quality of reconstruction?

Copy link
Collaborator

@kerrj kerrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

@ichsan2895
Copy link

ichsan2895 commented Jan 31, 2024

I got this error after I processing a dataset with ODM

feature-type: dspsift, mesh-octree-depth: 13, mesh-size: 300000, min-num-features: 15000, pc-quality: high, rolling-shutter: true, texturing-keep-unseen-faces: true, texturing-single-material: true, use-3dmesh: true

Then I download all of processed data, then copy-paste the images to images folder..

>> ls /path/to/ODM_result
images
odm_orthophoto
odm_report
images.json	    
cameras.json				    
entwine_pointcloud
log.json
odm_georeferencing
task_output.txt
odm_texturing
>> ns-process-data odm --data /path/to/ODM_result --output-dir MY_DATASET

FileNotFoundError: [Errno 2] No such file or directory: '/path/to/ODM_result/opensfm/reconstruction.json'

@pierotofy
Copy link
Contributor Author

pierotofy commented Jan 31, 2024

You didn't process it with ODM (https://github.com/OpenDroneMap/ODM), you used NodeODM or WebODM. You'll need the opensfm folder, which is only available when you process with ODM.

@kerrj kerrj merged commit c5a400c into nerfstudio-project:main Feb 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants