Replace depth alpha mask logic with torch.where for gradients in splatfacto #2856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 70ade42.
This reverts commit 70d83d4.
jb-ye
reviewed
Jan 31, 2024
| @@ -779,8 +779,7 @@ def get_outputs(self, camera: Cameras) -> Dict[str, Union[torch.Tensor, List]]: | |||
| W, | |||
| background=torch.zeros(3, device=self.device), | |||
| )[..., 0:1] # type: ignore | |||
| depth_im[alpha > 0] = depth_im[alpha > 0] / alpha[alpha > 0] | |||
| depth_im[alpha == 0] = 1000 | |||
| depth_im = torch.where(alpha > 0, depth_im / alpha, depth_im.detach().max()) | |||
There was a problem hiding this comment.
Just an unrelated comment, compute the mean(depth) has very high variance in estimation. I would prefer to compute mean(1/depth) as this is more related to disparity maps across views.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.