Fix depth-nerfacto edge cases #2939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…udio-project/nerfstudio into ethan/fix_depth_nerfacto_sampling
kerrj
reviewed
Feb 21, 2024
nerfstudio/data/pixel_samplers.py
Outdated
|
|
||
| if "mask" in batch: | ||
| num_rays_in_batch = num_rays_per_batch // num_images | ||
| if num_rays_in_batch % 2 != 0: |
There was a problem hiding this comment.
this could be moved above if statement and 293-294 deleted right?
kerrj
approved these changes
Feb 21, 2024
Michael-Spleenlab
pushed a commit
to Michael-Spleenlab/nerfstudio
that referenced
this pull request
Apr 26, 2024
* fixes pixel sampling * reverting indexing change * adressing PR change --------- Co-authored-by: Justin Kerr <justin.g.kerr@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depth nerfacto doesn't work unless num_rays_in_batch is divisible by 2. Also, the depth images are in a list and not just a batch tensor, so I think the changes I made are needed.