Fix dimension mismatch between downscaled cameras and images in colmap. #3232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When running
splatfacto
with my custom dataset of images with varying resolutions, I encountered a dimension mismatch error between the downscaled cameras and images. This issue arises because the_downscale_images
function incolmap_dataparser.py
(L484) uses a fixed downscaling size for every image.Proposed Solution: Modify
_downscale_images
to compute the downscaling size individually for each image to ensure compatibility with images of different resolutions.