Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP idiom designation #111

Closed
5 tasks done
nschneid opened this issue Jul 23, 2018 · 16 comments
Closed
5 tasks done

PP idiom designation #111

nschneid opened this issue Jul 23, 2018 · 16 comments

Comments

@nschneid
Copy link
Contributor

nschneid commented Jul 23, 2018

I just pushed (efee7c5) an improvement to the language pages that subcategorizes the adpositions according to single-word/multiword/PP idiom and shows their transitivity.

  • As you can see, with the current database, most of the PP idioms are listed as transitive, but should be intransitive (as discussed in PP idioms #99).

Additionally, there are borderline cases where we need a clearer definition of PP idiom vs. multiword P. (@ablodge, did you import the distinction from STREUSLE's lexcat or implement it some other way? STREUSLE may not be 100% consistent.) How about the following definition:

A PP idiom is a fixed or semi-fixed expression consisting of an adposition plus its complement (usually an NP, AdjP, or AdvP), which must be a complete phrase. In some of these expressions the complement may take variable modifiers (e.g., "on ONE's own"). The PP idiom as a whole does not take a complement (is intransitive). A fixed expression ending in a transitive preposition like "of" or "as" ("in search of", "as long as") requires a complement, and thus is not a PP idiom. [Infinitive marker "to" counts as a transitive preposition for purposes of this definition.]

  • I would say the following should be added as PP idioms:

    • in_this_day [short for "in this day and age", presumably]
    • infinitive TO+verb: to_eat, to_go
  • in_hope_to, just_about, nothing_but probably should not be considered PP idioms, because they are transitive.

  • back_and_forth (intr.), up_and_run(ning) (intr.) are listed as PP idioms whereas over_and_above (tr.) is not. My gut feeling is that neither should be considered a PP idiom. We could clarify the definition:

    A fixed phrase with only intransitive prepositions ("back and forth", "up and run(ning)") is not a PP idiom, because there are no complements.

  • out_front, out_there, up_front: These seem borderline to me because they're schematic spatial descriptions. What do you think?

@nschneid
Copy link
Contributor Author

nschneid commented Jul 23, 2018

  • In the database, 's, at, and toward still have is_pp_idiom==None

@ablodge
Copy link
Contributor

ablodge commented Jul 23, 2018

I relied on presence of an object in streusle to determine transitivity. This is an easy fix. I guess we also want to not list objects for pp idioms?

For most of these other decisions, we’ll want to edit the metadata by hand.

@ablodge
Copy link
Contributor

ablodge commented Jul 23, 2018

did you import the distinction from STREUSLE's lexcat or implement it some other way?

I just use lexcat.

ablodge added a commit that referenced this issue Jul 23, 2018
@ablodge
Copy link
Contributor

ablodge commented Jul 23, 2018

I'm actually having trouble editing the metadata by hand. @nschneid Do you have an idea why that would be?

@nschneid
Copy link
Contributor Author

What problem are you encountering? I was able to edit the transitivity of "rather_than" in the metadata pane.

@ablodge
Copy link
Contributor

ablodge commented Jul 23, 2018

I can't edit is_pp_idiom in the metadata (I click update and it ignores the new value). Is there something that needs to be set?

@nschneid
Copy link
Contributor Author

Hmm that's weird—it's working for me. Only things I can think of are a caching issue, or a user permissions issue.

@ablodge
Copy link
Contributor

ablodge commented Jul 23, 2018

I can change is_pp_idiom from True to False, but not False to True. I've tried several times. (Also false is the default)

@nschneid
Copy link
Contributor Author

Oh, yes, I can reproduce that. Strange. The navlink checkbox on language articles works—is the form logic being handled in the same way?

@ablodge
Copy link
Contributor

ablodge commented Jul 24, 2018

Not sure. I'm still not sure how to resolve this, but in the worst case, we can delete the adpositions 'in_this_day', 'to_go', and 'to_eat' and remake them by hand then run the importer again to re-add usages and ptokens. I've tried it locally and it works.

@ablodge
Copy link
Contributor

ablodge commented Jul 24, 2018

out_front, out_there, up_front: These seem borderline to me because they're schematic spatial descriptions. What do you think?

They meet the description of PP idioms you described above. They have to be idiomatic since they don't fit the normal gov-obj relationship for these adpositions (out there ≠ out the box). I'd prefer to keep them in pp idioms unless you can think of a good criterion to do otherwise.

@nschneid
Copy link
Contributor Author

Aha, I think I solved the checkbox bug: is_pp_idiom isn't included in the set returned by Adposition.field_names(). This set is used by Metadata.newRevision() to determine which metadata fields have values to be updated.

https://github.com/nert-gu/Xposition/blob/83621db5586f9fe8f29ca6fea20fc841163c289f/wiki/plugins/metadata/models.py#L669-L672

@nschneid
Copy link
Contributor Author

I'd prefer to keep them in pp idioms

Fine with me.

@ablodge
Copy link
Contributor

ablodge commented Jul 24, 2018

Confirmed! It works.

ablodge added a commit that referenced this issue Jul 24, 2018
handle the few cases we decided in the script
@ablodge ablodge closed this as completed Jul 24, 2018
@ablodge
Copy link
Contributor

ablodge commented Jul 24, 2018

Can you add a link to the description of PP Idioms and I'll put it in the create adposition instructions?

@nschneid
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants