Fix devices#index status weirdness #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhunleth
approved these changes
May 1, 2019
Turns out when I moved the devices#index page to LiveView, I forgot to remote the js code connecting to a socket and watching for presence change events. So every now and then there was a race condition between the JS updating devices statuses on the page and LiveView. So to fix, 💥 the socket javascript!
jjcarstens
force-pushed
the
fix_devices_index
branch
from
de047b7
to
a2e5f38
Compare
|
So previously I updated So I removed those updates and will work on cleaning that up later. For now, this is good to go |
mobileoverlord
approved these changes
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out when I moved the devices#index page to LiveView, I forgot to remote the js
code connecting to a socket and watching for presence change events. So every now and
then there was a race condition between the JS updating devices statuses on the page
and LiveView.
So to fix, 💥 the socket javascript!
(Thanks to @mobileoverlord and @chrismccord for helping find this craziness)