Don't crash on redundant network present notifications #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I think this PR is good, I'm not convinced that there isn't a bug lurking as well. It seems like it should have been harder for me to trigger this issue than it was. |
fhunleth
force-pushed
the
dont-crash-redundant-notif
branch
from
3da89e6
to
7b096bf
Compare
These really shouldn't happen much, but I saw what that did and it seemed like crashing was too harsh.
fhunleth
force-pushed
the
dont-crash-redundant-notif
branch
from
7b096bf
to
cbda23b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These really shouldn't happen much, but I saw what that did and it
seemed like crashing was too harsh.