Extract PropertyTable to its own library #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fhunleth
force-pushed
the
property_table2
branch
3 times, most recently
from
5f969c8
to
fd09d80
Compare
*Backwards incompatible - please read* PropertyTable is now its own library and it has been simplified. While some API affecting changes to PropertyTable were made in the library to fix bugs, improve performance and make it more generic, this preserves the PropertyTable semantics as much as possible to avoid application code needing to change. I don't believe any user code should need to change. The backwards incompatible part of this change is that all references to `VintageNet.PropertyTable` need to be changed to `PropertyTable`. This shouldn't affect most code, but does affect `vintage_net_wifi`. This fixes #352.
fhunleth
force-pushed
the
property_table2
branch
from
fd09d80
to
53e9ae3
Compare
ConnorRigby
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backwards incompatible - please read
PropertyTable is now its own library and it has been simplified. While
some API affecting changes to PropertyTable were made in the library to
fix bugs, improve performance and make it more generic, this preserves
the PropertyTable semantics as much as possible to avoid application
code needing to change. I don't believe any user code should need to
change.
The backwards incompatible part of this change is that all references to
VintageNet.PropertyTableneed to be changed toPropertyTable. Thisshouldn't affect most code, but does affect
vintage_net_wifi.This fixes #352.