Add missing auth id(0x02~0x05) #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
including * eos * tron * bitcoin * dogecoin Add hash functions: sha256 and ripemd160 Fix rust toolchains Code format
XuJiandong
force-pushed
the
add-missing-auth-ids
branch
from
a4351c0
to
0b55623
Compare
contrun
approved these changes
Jan 4, 2024
* Add testcase : EOS Tron Bitcoin Dogecoin
|
Review Guide:
|
doitian
reviewed
Jan 8, 2024
doitian
reviewed
Jan 8, 2024
doitian
approved these changes
Jan 8, 2024
xxuejie
reviewed
Jan 8, 2024
omni_lock_commit_id_00191199.gz unzip and check hash by ckb-cli: |
|
For those who want to test with lumos, here is the reference implementation: |
doitian
added a commit
to cryptape/ckb-dao-cobuild-poc
that referenced
this pull request
Jan 10, 2024
What's changed: - Switch to the deployment information of Omnilock - args: append 00. It is the omni lock flag byte, which indicate there's no advanced omni lock features been used. - `WitnessArgs.lock` size: 65 to 85, this is the size of a `OmnilockWitnessLock` to only save a 65-byte signature. - witness: instead of storing the 65-byte signature directly into `WitnessArgs.lock`, pack it into a `OmnilockWitnessLock`. Omnilock Contract Error Codes For Reference: - 8: args format is wrong - 5: `WitnessArgs.lock` is not a valid `OmnilockWitnessLock` [An example deposit in testnet](https://pudge.explorer.nervos.org/transaction/0x7bc9bd9a60852bf85d7142041867fb3d92b44a0d5821835fef9b1978442e84c0) Omnilock info: | parameter | value | | ----------- | -------------------------------------------------------------------- | | `code_hash` | 0xf329effd1c475a2978453c8600e1eaf0bc2087ee093c3ee64cc96ec6847752cb | | `hash_type` | `type` | | `tx_hash` | 0xff234bf2fb0ad2ab5b356ceda317d3dee3efb2c55b9427ef55d9dcbf6eecbf9f | | `index` | `0x0` | | `dep_type` | `code` | Related PRs: nervosnetwork/ckb-production-scripts#75 Closes #12
XuJiandong
force-pushed
the
add-missing-auth-ids
branch
2 times, most recently
from
6702653
to
5e8c467
Compare
* Display message on wallet with meaningful words. like below: You're sining: CKB transaction: 001122334455... works for bitcoin and ethereum * add new ethereum algorithm id(18) for displaying message * update bitcoin algorithm id * keep eos/tron/dogecoin as same to PW * Add trait: ChainConfig, used for other on-chain signatures * Add eth displaying testcase (#5)
XuJiandong
force-pushed
the
add-missing-auth-ids
branch
from
12027c3
to
3bc30c8
Compare
|
Is the new |
* Add 0x at the beginning of prefix
|
deployed on testnet(commit: f884d9):
|
XuJiandong
added a commit
to XuJiandong/omnilock
that referenced
this pull request
Jan 12, 2024
migrate PR from: nervosnetwork/ckb-production-scripts#75 including * eos * tron * bitcoin(Support UniSat and OKX wallet) * dogecoin Special feature for btc/etc, now they can display meaningful messages. * BTC(UniSat/OKX) You're signing: CKB (Bitcoin Layer-2) transaction: 0x{sighash_all in hex} * ETH(Metamask) You're signing: CKB transaction: 0x{sighash_all in hex}
XuJiandong
added a commit
to cryptape/omnilock
that referenced
this pull request
Jan 22, 2024
* Add missing auth id(0x02~0x05) migrate PR from: nervosnetwork/ckb-production-scripts#75 including * eos * tron * bitcoin(Support UniSat and OKX wallet) * dogecoin Special feature for btc/etc, now they can display meaningful messages. * BTC(UniSat/OKX) You're signing: CKB (Bitcoin Layer-2) transaction: 0x{sighash_all in hex} * ETH(Metamask) You're signing: CKB transaction: 0x{sighash_all in hex} * Fix: Remove btc testcase annotation (#2) * Change Bitcoin Prefix (#10) --------- Co-authored-by: joii2020 <87224197+joii2020@users.noreply.github.com>
XuJiandong
added a commit
to XuJiandong/omnilock
that referenced
this pull request
Jan 22, 2024
migrate PR from: nervosnetwork/ckb-production-scripts#75 including * eos * tron * bitcoin(Support UniSat and OKX wallet) * dogecoin Special feature for btc/etc, now they can display meaningful messages. * BTC(UniSat/OKX) You're signing: CKB (Bitcoin Layer-2) transaction: 0x{sighash_all in hex} * ETH(Metamask) You're signing: CKB transaction: 0x{sighash_all in hex}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE
This PR is migrated to here.
The omnilock is moved to new repo.
including
Special feature for btc/etc, now they can display meaningful messages like below:
Other changes: