feat: extends hash_type to 'data' | 'type' | 'data1' #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extends hash_type to 'data' | 'type' | 'data1' and update serializer to handle 'data1' ref https://github.com/nervosnetwork/rfcs/blob/c0aacf775a347ec44b3b0c02ba6dd67a5a47128c/rfcs/0032-ckb-vm-version-selection/0032-ckb-vm-version-selection.md
Codecov Report
@@ Coverage Diff @@
## develop #555 +/- ##
===========================================
+ Coverage 96.27% 96.29% +0.02%
===========================================
Files 50 49 -1
Lines 1556 1540 -16
Branches 297 302 +5
===========================================
- Hits 1498 1483 -15
+ Misses 58 57 -1
|
…_version Add a new format of full address, which identifies the hash_type and vm_version ref nervosnetwork/rfcs#239
1. import bech32, bech32m from an external pacakge 2. update format of the new full address
feat: add full version address identifies the hash_type
shaojunda
approved these changes
Oct 8, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends hash_type to 'data' | 'type' | 'data1' and update serializer to handle 'data1'
ref
https://github.com/nervosnetwork/rfcs/blob/c0aacf775a347ec44b3b0c02ba6dd67a5a47128c/rfcs/0032-ckb-vm-version-selection/0032-ckb-vm-version-selection.md