feat: using delayed verify #158

kilb · 2019-01-06T15:54:19Z

No description provided.

core/src/cell.rs

core/src/header.rs

core/src/transaction_meta.rs

shared/src/txo_set.rs

chain/src/chain.rs

shared/src/txo_set.rs

+        self.inner.insert(hash, TransactionMeta::new(outputs_len));
+    }
+
+    pub fn remove(&mut self, hash: &H256) -> Option<TransactionMeta> {


doitian

Hold this PR since the commit messages will not generate meaningful CHANGELOG. I'm going to squash merge it when this is ready.

doitian

It is really hard to reason the logic in get_forks and reconcile_main_chain. Please add some documents and make them easier to read.

chain/src/chain.rs

doitian · 2019-01-26T13:31:13Z

@kilb conflict with #223 , could you resolve the conflicts?

quake · 2019-01-27T01:40:38Z

chain/src/chain.rs

+            received_at: unix_time_as_millis(),
+            total_difficulty: cannon_total_difficulty.clone(),
+            total_uncles_count: parent_ext.total_uncles_count + block.uncles().len() as u64,
+            valid: if parent_ext.valid == Some(false) {


Why continue processing the new block here if its parent block validation result is false?

we should save it

We can just save this ext and quit.

core/src/header.rs

shared/src/shared.rs

1579: chore(deps): bump futures from 0.1.28 to 0.1.29 r=doitian a=dependabot-preview[bot] [//]: # (dependabot-start) ⚠️ **Dependabot is rebasing this PR** ⚠️ If you make any changes to it yourself then they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [futures](https://github.com/rust-lang-nursery/futures-rs) from 0.1.28 to 0.1.29. <details> <summary>Commits</summary> - [`56f8eb9`](rust-lang/futures-rs@56f8eb9) 0.1.29 release - [`ad7830d`](rust-lang/futures-rs@ad7830d) add must_use attributes on Future and Stream - See full diff in [compare view](rust-lang/futures-rs@0.1.28...0.1.29) </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=futures&package-manager=cargo&previous-version=0.1.28&new-version=0.1.29)](https://dependabot.com/compatibility-score.html?dependency-name=futures&package-manager=cargo&previous-version=0.1.28&new-version=0.1.29) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details> 1580: chore(deps): bump secp256k1 from 0.15.1 to 0.15.5 r=doitian a=dependabot-preview[bot] [//]: # (dependabot-start) ⚠️ **Dependabot is rebasing this PR** ⚠️ If you make any changes to it yourself then they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [secp256k1](https://github.com/rust-bitcoin/rust-secp256k1) from 0.15.1 to 0.15.5. <details> <summary>Changelog</summary> *Sourced from [secp256k1's changelog](https://github.com/rust-bitcoin/rust-secp256k1/blob/master/CHANGELOG.md).* > > # 0.15.4 - 2019-09-06 > > - Add `rand-std` feature. > - Pin the cc build-dep version to `< 1.0.42` to remain > compatible with rustc 1.22.0. > - Changed all `as_*ptr()` to a new safer `CPtr` trait > > # 0.15.2 - 2019-08-08 > > - Add feature `lowmemory` that reduces the EC mult window size to require > significantly less memory for the validation context (~680B instead of > ~520kB), at the cost of slower validation. It does not affect the speed of > signing, nor the size of the signing context. > > # 0.15.0 - 2019-07-25 > > * Implement hex human-readable serde for PublicKey > * Implement fmt::LowerHex for SecretKey and PublicKey > * Relax `cc` dependency requirements > * Add links manifest key to prevent cross-version linkage > > # 0.14.1 - 2019-07-14 > > * Implemented FFI functions: `secp256k1_context_create` and `secp256k1_context_destroy` in rust. > > # 0.14.0 - 2019-07-08 > > * [Feature-gate endormorphism optimization](https://github-redirect.dependabot.com/rust-bitcoin/rust-secp256k1/pull/120) > because of a lack of clarity with respect to patents > * Got full no-std support including eliminating all use of libc in C bindings. > [PR 1](https://github-redirect.dependabot.com/rust-bitcoin/rust-secp256k1/pull/115) > [PR 2](https://github-redirect.dependabot.com/rust-bitcoin/rust-secp256k1/pull/125). > This library should be usable in bare-metal environments and with rust-wasm. > Thanks to Elichai Turkel for driving this forward! > > # 0.13.0 - 2019-05-21 > > * Update minimum supported rust compiler 1.22. > * Replace `serialize_der` function with `SerializedSignature` struct. > * Allow building without a standard library (`no_std`). `std` feature is on by default. > * Add human readable serialization to `Signatures` and `SecretKeys`. > * Stop displaying 0 bytes if a `Signature` is less than 72 bytes. > * Only compile recovery module if feature `recovery` is set (non-default). > * Update `rand` dependency from 0.4 to 0.6 and add `rand_core` 0.4 dependency. > * Relax `cc` dependency requirements. > > # 0.12.2 - 2019-01-18 > > * Fuzzer bug fix ></tr></table> ... (truncated) </details> <details> <summary>Commits</summary> - [`f5c8a00`](rust-bitcoin/rust-secp256k1@f5c8a00) Merge pull request [#159](https://github-redirect.dependabot.com/rust-bitcoin/rust-secp256k1/issues/159) from rust-bitcoin/2019-09-0155 - [`0c901db`](rust-bitcoin/rust-secp256k1@0c901db) bump version to 0.15.5 - [`0e5e314`](rust-bitcoin/rust-secp256k1@0e5e314) Merge pull request [#158](https://github-redirect.dependabot.com/rust-bitcoin/rust-secp256k1/issues/158) from rust-bitcoin/revert-153-2019-08-rand-std-feature - [`bbab1c2`](rust-bitcoin/rust-secp256k1@bbab1c2) Revert "Add a rand-std feature" - [`4bcb404`](rust-bitcoin/rust-secp256k1@4bcb404) Merge [#156](https://github-redirect.dependabot.com/rust-bitcoin/rust-secp256k1/issues/156): Pin version of build dependency cc to <1.0.42 - [`845bff2`](rust-bitcoin/rust-secp256k1@845bff2) Bump version to 0.15.4 - [`07ef3a1`](rust-bitcoin/rust-secp256k1@07ef3a1) Pin version of build dependency cc to <1.0.42 - [`4e69dcc`](rust-bitcoin/rust-secp256k1@4e69dcc) Merge pull request [#153](https://github-redirect.dependabot.com/rust-bitcoin/rust-secp256k1/issues/153) from elichai/2019-08-rand-std-feature - [`b59f4ff`](rust-bitcoin/rust-secp256k1@b59f4ff) Add a rand-std feature - [`eddfe03`](rust-bitcoin/rust-secp256k1@eddfe03) Merge pull request [#151](https://github-redirect.dependabot.com/rust-bitcoin/rust-secp256k1/issues/151) from elichai/2019-08-Cptr-null - Additional commits viewable in [compare view](rust-bitcoin/rust-secp256k1@0.15.1...0.15.5) </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=secp256k1&package-manager=cargo&previous-version=0.15.1&new-version=0.15.5)](https://dependabot.com/compatibility-score.html?dependency-name=secp256k1&package-manager=cargo&previous-version=0.15.1&new-version=0.15.5) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

1580: chore(deps): bump secp256k1 from 0.15.1 to 0.15.5 r=zhangsoledad a=dependabot-preview[bot] Bumps [secp256k1](https://github.com/rust-bitcoin/rust-secp256k1) from 0.15.1 to 0.15.5. <details> <summary>Changelog</summary> *Sourced from [secp256k1's changelog](https://github.com/rust-bitcoin/rust-secp256k1/blob/master/CHANGELOG.md).* > > # 0.15.4 - 2019-09-06 > > - Add `rand-std` feature. > - Pin the cc build-dep version to `< 1.0.42` to remain > compatible with rustc 1.22.0. > - Changed all `as_*ptr()` to a new safer `CPtr` trait > > # 0.15.2 - 2019-08-08 > > - Add feature `lowmemory` that reduces the EC mult window size to require > significantly less memory for the validation context (~680B instead of > ~520kB), at the cost of slower validation. It does not affect the speed of > signing, nor the size of the signing context. > > # 0.15.0 - 2019-07-25 > > * Implement hex human-readable serde for PublicKey > * Implement fmt::LowerHex for SecretKey and PublicKey > * Relax `cc` dependency requirements > * Add links manifest key to prevent cross-version linkage > > # 0.14.1 - 2019-07-14 > > * Implemented FFI functions: `secp256k1_context_create` and `secp256k1_context_destroy` in rust. > > # 0.14.0 - 2019-07-08 > > * [Feature-gate endormorphism optimization](https://github-redirect.dependabot.com/rust-bitcoin/rust-secp256k1/pull/120) > because of a lack of clarity with respect to patents > * Got full no-std support including eliminating all use of libc in C bindings. > [PR 1](https://github-redirect.dependabot.com/rust-bitcoin/rust-secp256k1/pull/115) > [PR 2](https://github-redirect.dependabot.com/rust-bitcoin/rust-secp256k1/pull/125). > This library should be usable in bare-metal environments and with rust-wasm. > Thanks to Elichai Turkel for driving this forward! > > # 0.13.0 - 2019-05-21 > > * Update minimum supported rust compiler 1.22. > * Replace `serialize_der` function with `SerializedSignature` struct. > * Allow building without a standard library (`no_std`). `std` feature is on by default. > * Add human readable serialization to `Signatures` and `SecretKeys`. > * Stop displaying 0 bytes if a `Signature` is less than 72 bytes. > * Only compile recovery module if feature `recovery` is set (non-default). > * Update `rand` dependency from 0.4 to 0.6 and add `rand_core` 0.4 dependency. > * Relax `cc` dependency requirements. > > # 0.12.2 - 2019-01-18 > > * Fuzzer bug fix ></tr></table> ... (truncated) </details> <details> <summary>Commits</summary> - [`f5c8a00`](rust-bitcoin/rust-secp256k1@f5c8a00) Merge pull request [#159](https://github-redirect.dependabot.com/rust-bitcoin/rust-secp256k1/issues/159) from rust-bitcoin/2019-09-0155 - [`0c901db`](rust-bitcoin/rust-secp256k1@0c901db) bump version to 0.15.5 - [`0e5e314`](rust-bitcoin/rust-secp256k1@0e5e314) Merge pull request [#158](https://github-redirect.dependabot.com/rust-bitcoin/rust-secp256k1/issues/158) from rust-bitcoin/revert-153-2019-08-rand-std-feature - [`bbab1c2`](rust-bitcoin/rust-secp256k1@bbab1c2) Revert "Add a rand-std feature" - [`4bcb404`](rust-bitcoin/rust-secp256k1@4bcb404) Merge [#156](https://github-redirect.dependabot.com/rust-bitcoin/rust-secp256k1/issues/156): Pin version of build dependency cc to <1.0.42 - [`845bff2`](rust-bitcoin/rust-secp256k1@845bff2) Bump version to 0.15.4 - [`07ef3a1`](rust-bitcoin/rust-secp256k1@07ef3a1) Pin version of build dependency cc to <1.0.42 - [`4e69dcc`](rust-bitcoin/rust-secp256k1@4e69dcc) Merge pull request [#153](https://github-redirect.dependabot.com/rust-bitcoin/rust-secp256k1/issues/153) from elichai/2019-08-rand-std-feature - [`b59f4ff`](rust-bitcoin/rust-secp256k1@b59f4ff) Add a rand-std feature - [`eddfe03`](rust-bitcoin/rust-secp256k1@eddfe03) Merge pull request [#151](https://github-redirect.dependabot.com/rust-bitcoin/rust-secp256k1/issues/151) from elichai/2019-08-Cptr-null - Additional commits viewable in [compare view](rust-bitcoin/rust-secp256k1@0.15.1...0.15.5) </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=secp256k1&package-manager=cargo&previous-version=0.15.1&new-version=0.15.5)](https://dependabot.com/compatibility-score.html?dependency-name=secp256k1&package-manager=cargo&previous-version=0.15.1&new-version=0.15.5) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) Finally, you can contact us by mentioning @dependabot. </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

kilb added 6 commits January 6, 2019 19:00

using delayed verify

eb26291

remove avl

80f5514

fix tests

01f2189

make clippy

bfb03ef

make clone consensus cheaper

8d780d9

merge develop

64d9b71

kilb requested review from zhangsoledad, TheWaWaR, quake and doitian January 6, 2019 15:54

doitian mentioned this pull request Jan 7, 2019

Verify PoW first, fully verify the block only when moving best chain tip #146

Closed

merge develop

b453777

doitian changed the title ~~using delayed verify~~ [HOLD] using delayed verify Jan 8, 2019

quake requested changes Jan 8, 2019

View reviewed changes

quake reviewed Jan 8, 2019

View reviewed changes

chain/src/chain.rs Show resolved Hide resolved

quake added 2 commits January 10, 2019 10:46

chore: remove unused fn

430b428

chore: make some fn private

3716492

quake mentioned this pull request Jan 18, 2019

[HOLD] feat: delayed verification refactoring #207

Closed

merge develop

61b90a6

kilb changed the title ~~[HOLD] using delayed verify~~ using delayed verify Jan 25, 2019

kilb changed the title ~~using delayed verify~~ feat: using delayed verify Jan 25, 2019

quake approved these changes Jan 25, 2019

View reviewed changes

doitian reviewed Jan 26, 2019

View reviewed changes

shared/src/txo_set.rs

self.inner.insert(hash, TransactionMeta::new(outputs_len));

}

pub fn remove(&mut self, hash: &H256) -> Option<TransactionMeta> {

This comment was marked as off-topic.

Sign in to view

doitian mentioned this pull request Jan 26, 2019

Limit TXO set memory usage #228

Closed

doitian requested changes Jan 26, 2019

View reviewed changes

fix: fix bug

73f2735

doitian approved these changes Jan 26, 2019

View reviewed changes

Merge branch 'develop' into kilb/delayed_verify

e0a8e1a

merge develop

9d8fe65

quake requested changes Jan 27, 2019

View reviewed changes

kilb added 3 commits January 28, 2019 10:47

fix: reduce memory use when init

fb8f379

style: use blocknum instead

3c467b3

chore: remove RichHeader

ebe01f4

quake approved these changes Jan 30, 2019

View reviewed changes

doitian merged commit 07d6a69 into develop Jan 30, 2019

doitian deleted the kilb/delayed_verify branch January 30, 2019 05:49

doitian mentioned this pull request Feb 11, 2019

Rc/v0.6.0 #266

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: using delayed verify #158

feat: using delayed verify #158

kilb commented Jan 6, 2019

This comment was marked as off-topic.

doitian left a comment

doitian left a comment

doitian commented Jan 26, 2019

quake Jan 27, 2019

kilb Jan 28, 2019

doitian Jan 29, 2019

feat: using delayed verify #158

feat: using delayed verify #158

Conversation

kilb commented Jan 6, 2019

This comment was marked as off-topic.

doitian left a comment

Choose a reason for hiding this comment

doitian left a comment

Choose a reason for hiding this comment

doitian commented Jan 26, 2019

quake Jan 27, 2019

Choose a reason for hiding this comment

kilb Jan 28, 2019

Choose a reason for hiding this comment

doitian Jan 29, 2019

Choose a reason for hiding this comment