Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD] feat: delayed verification refactoring #207

Closed
wants to merge 17 commits into from
Closed

[HOLD] feat: delayed verification refactoring #207

wants to merge 17 commits into from

Conversation

quake
Copy link
Member

@quake quake commented Jan 18, 2019 •
edited
Loading

This PR contains several changes:

  1. Merged feat: using delayed verify #158 removal of AVL
  2. Defer the full verification until we really need to move the best chain tip
  3. Refactoring notify module, remove Arc in notify message.
  4. Change BlockAssembler#candidate_uncles from LruCache to VecDeque

@quake quake changed the title delayed verify and refactoring feat: delayed verify and refactoring Jan 18, 2019
kilb
kilb suggested changes Jan 18, 2019
View reviewed changes
shared/src/index.rs Outdated Show resolved Hide resolved
@quake quake force-pushed the quake/delayed_verify branch 2 times, most recently from 911fdc3 to b0e233a Compare January 22, 2019 01:57
zhangsoledad
zhangsoledad reviewed Jan 23, 2019
View reviewed changes
shared/src/store.rs Outdated Show resolved Hide resolved
miner/src/block_assembler.rs Show resolved Hide resolved
miner/src/block_assembler.rs Show resolved Hide resolved
kilb and others added 17 commits January 23, 2019 16:55
kilb
kilb suggested changes Jan 24, 2019
View reviewed changes
chain/src/chain.rs
debug!(target: "chain", " {} => {:?}", index, uncle);
}
debug!(target: "chain", "}}");
self.notify.notify_new_block(block_category);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If failed, the chain will have a different tip with pool.

@kilb kilb changed the title feat: delayed verify and refactoring [HOLD] feat: delayed verify and refactoring Jan 25, 2019
@kilb kilb changed the title [HOLD] feat: delayed verify and refactoring [HOLD] feat: refactoring Jan 25, 2019
@doitian doitian changed the title [HOLD] feat: refactoring [HOLD] feat: delayed verification refactoring Jan 25, 2019
@doitian doitian added the s:discussion-needed Status: Need to Discuss label Feb 12, 2019
@doitian
Copy link
Member

doitian commented Feb 22, 2019

Close since it is based on a very old version.

@doitian doitian closed this Feb 22, 2019
@quake quake deleted the quake/delayed_verify branch March 13, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangsoledad zhangsoledad zhangsoledad left review comments

@kilb kilb kilb requested changes

@doitian doitian Awaiting requested review from doitian

Assignees
No one assigned
Labels
s:discussion-needed Status: Need to Discuss
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@quake @doitian @zhangsoledad @kilb