Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ckb cli secp256k1-lock should return a single bytes as args #1746

Closed
doitian opened this issue Oct 22, 2019 · 0 comments · Fixed by #1763
Closed

ckb cli secp256k1-lock should return a single bytes as args #1746

doitian opened this issue Oct 22, 2019 · 0 comments · Fixed by #1763
Labels
good first issue Good for newcomers t:bug Type: This doesn't seem right.

Comments

@doitian
Copy link
Member

doitian commented Oct 22, 2019

Environment

  • CKB version: v0.23.0
  • Chain: testnet
  • Operating system: macOS
  • Arch: x64
  • Installation: Built from source

Describe the bug

$ target/release/ckb cli secp256k1-lock 049b34df88f4e1364d32ab7f5fe5b25d60c56c686500925e3b87e2f5d989a8b0f9d8b8376d352ee5a1c70f061b59c4b6799
68fe84b3f09ab2ee03f760e21150ef9
# args = [ "ckb cli blake160 <compressed-pubkey>" ]                                                                                                                
args = [ "0xde9ed127a494d92342d68b0424986dd69530be30" ]
@doitian doitian added good first issue Good for newcomers t:bug Type: This doesn't seem right. labels Oct 22, 2019
@driftluo driftluo mentioned this issue Oct 26, 2019
Merged
bors bot added a commit that referenced this issue Oct 29, 2019
@bors @driftluo
Merge #1763
4375414 
1763: fix: fix cli output and ban reason r=quake a=driftluo

1. fix #1746
2. add reason on `ban_peer` in cx trait

Co-authored-by: driftluo <driftluo@foxmail.com>
bors bot added a commit that referenced this issue Oct 29, 2019
@bors @driftluo @xxuejie
Merge #1763 #1769
61b8b76 
1763: fix: fix cli output and ban reason r=quake a=driftluo

1. fix #1746
2. add reason on `ban_peer` in cx trait

1769: feat: Adapt to 2-phase Nervos DAO implementation r=doitian a=xxuejie

Depends on nervosnetwork/ckb-system-scripts#59

Co-authored-by: driftluo <driftluo@foxmail.com>
Co-authored-by: Xuejie Xiao <xxuejie@gmail.com>
@bors bors bot closed this as completed in 423db2c Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers t:bug Type: This doesn't seem right.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fix cli output and ban reason driftluo/ckb
1 participant
@doitian