Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.112.0 #4181

Closed
doitian opened this issue Oct 9, 2023 · 8 comments
Closed

Release v0.112.0 #4181

doitian opened this issue Oct 9, 2023 · 8 comments
Assignees

Comments

@doitian
Copy link
Member

doitian commented Oct 9, 2023

RC Date: 2023-10-16
Release Date: 2023-10-30

Features

Bug Fixes

Improvements

@doitian
Copy link
Member Author

doitian commented Oct 13, 2023

New changes since Oct 9th:

Bug Fixes

Improvements

@doitian
Copy link
Member Author

doitian commented Oct 27, 2023

New changes in RC2

@chenyukang
Copy link
Collaborator

chenyukang commented Nov 14, 2023

Breakchange notes

We introduce a huge code refactor on the transaction pool module and added the feature of RBF(Replace by Fee) in this release.

Here are two points need to be noted:

  1. Double-spending check now will work before any transaction is added to the transaction pool, a transaction that conflicts with current transactions in the pool will be rejected, the only way to add the new transaction into the pool is by improving the fee and if RBF checking passed, transaction pool will remove old conflicted transactions, then add the new one into pool.

  2. The RBF feature enables users to replace a transaction with a higher fee rate when pending in tx-pool, which is useful when the transaction is stuck in the tx-pool. More details about RBF:

The most important rule is fee, you need to pay an extra fee to replace old transactions with the new one. The default min_rbf_rate in ckb.toml is 1500, which means the minimum extra fee rate for RBF, the unit is shannons/KB.

min_replace_fee = sum(replaced_tx_fee) + (min_rbf_rate * size)

The replaced transaction will be removed from tx-pool and with the status Rejected. The RBF may replace a transaction in the status of Pending or Proposed, but the old transaction may still be committed if it was in Proposed.

@doitian
Copy link
Member Author

doitian commented Nov 17, 2023

Release rc3 for #4232 which reverts the default behavior introduced in #4181 (comment)

@doitian
Copy link
Member Author

doitian commented Nov 22, 2023

Breakchange notes

We introduce a huge code refactor on the transaction pool module and added the feature of RBF(Replace by Fee) in this release.

Here are two points need to be noted:

  1. Double-spending check now will work before any transaction is added to the transaction pool, a transaction that conflicts with current transactions in the pool will be rejected, the only way to add the new transaction into the pool is by improving the fee and if RBF checking passed, transaction pool will remove old conflicted transactions, then add the new one into pool.
  2. The RBF feature enables users to replace a transaction with a higher fee rate when pending in tx-pool, which is useful when the transaction is stuck in the tx-pool. More details about RBF:

The most important rule is fee, you need to pay an extra fee to replace old transactions with the new one. The default min_rbf_rate in ckb.toml is 1500, which means the minimum extra fee rate for RBF, the unit is shannons/KB.

min_replace_fee = sum(replaced_tx_fee) + (min_rbf_rate * size)

The replaced transaction will be removed from tx-pool and with the status Rejected.

@chenyukang Is this note up-to-dated after applying #4232 ?

@doitian
Copy link
Member Author

doitian commented Nov 22, 2023

Use v0.112.1 since v0.112.0 has been used to publish crates and cannot be reverted.

@chenyukang
Copy link
Collaborator

Breakchange notes

We introduce a huge code refactor on the transaction pool module and added the feature of RBF(Replace by Fee) in this release.
Here are two points need to be noted:

  1. Double-spending check now will work before any transaction is added to the transaction pool, a transaction that conflicts with current transactions in the pool will be rejected, the only way to add the new transaction into the pool is by improving the fee and if RBF checking passed, transaction pool will remove old conflicted transactions, then add the new one into pool.
  2. The RBF feature enables users to replace a transaction with a higher fee rate when pending in tx-pool, which is useful when the transaction is stuck in the tx-pool. More details about RBF:

The most important rule is fee, you need to pay an extra fee to replace old transactions with the new one. The default min_rbf_rate in ckb.toml is 1500, which means the minimum extra fee rate for RBF, the unit is shannons/KB.
min_replace_fee = sum(replaced_tx_fee) + (min_rbf_rate * size)
The replaced transaction will be removed from tx-pool and with the status Rejected.

@chenyukang Is this note up-to-dated after applying #4232 ?

I update with add a note:

The RBF may replace a transaction in the status of Pending or Proposed, but the old transaction may still be committed if it was in Proposed.

@doitian
Copy link
Member Author

doitian commented Nov 22, 2023

@doitian doitian closed this as completed Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants