Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

molecule: Remove deprecated SyncMessage union items. #4113

Merged
merged 4 commits into from Sep 18, 2023
Merged

molecule: Remove deprecated SyncMessage union items. #4113

merged 4 commits into from Sep 18, 2023

Conversation

eval-exec
Copy link
Collaborator

@eval-exec eval-exec commented Aug 23, 2023 •
edited by doitian

What problem does this PR solve?

Problem Summary:

Some union items in SyncMessage is deprecated, remove them.

What's Changed:

Related changes

  • [ ] TODO: Add a integration test 馃

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • None

Release note 

Title Only: Include this PR title in the release note.

@eval-exec eval-exec marked this pull request as ready for review September 16, 2023 06:23
@eval-exec eval-exec requested a review from a team as a code owner September 16, 2023 06:23
@eval-exec eval-exec requested review from quake and removed request for a team September 16, 2023 06:23
doitian
doitian approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@doitian doitian left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to be included in release note

@doitian doitian added this pull request to the merge queue Sep 18, 2023
Merged via the queue into nervosnetwork:develop with commit 49b05e1 Sep 18, 2023
35 checks passed
@doitian doitian mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@doitian doitian doitian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eval-exec @quake @doitian