Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RPC doc for deindex_lock_hash #1065

Merged
merged 2 commits into from
Jun 19, 2019
Merged

fix: RPC doc for deindex_lock_hash #1065

merged 2 commits into from
Jun 19, 2019

Conversation

ashchan
Copy link
Contributor

@ashchan ashchan commented Jun 19, 2019

It always returns null, instead of empty array.

@ashchan ashchan requested a review from a team June 19, 2019 08:51
@nervos-bot
Copy link

nervos-bot bot commented Jun 19, 2019

@xxuejie is assigned as the chief reviewer

@ashchan ashchan requested review from quake and doitian June 19, 2019 08:51
@ashchan ashchan changed the title fix: RPC doc for deindex_lock_hash fix: RPC doc for deindex_lock_hash [HOLD] Jun 19, 2019
nervos-bot[bot]
nervos-bot bot previously requested changes Jun 19, 2019
Copy link

@nervos-bot nervos-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold as requested by @ashchan.

@ashchan ashchan changed the title fix: RPC doc for deindex_lock_hash [HOLD] fix: RPC doc for deindex_lock_hash Jun 19, 2019
@nervos-bot nervos-bot bot dismissed their stale review June 19, 2019 09:03

Unhold as requested by @ashchan.

@ashchan ashchan requested a review from quake June 19, 2019 09:33
@quake quake merged commit e227f1c into nervosnetwork:develop Jun 19, 2019
@ashchan ashchan deleted the fix-indexer-rpc-doc branch June 19, 2019 12:48
This was referenced Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants