Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ᚬmaster] Rc/v0.15.0 #1091

Merged
merged 261 commits into from
Jun 29, 2019
Merged

[ᚬmaster] Rc/v0.15.0 #1091

merged 261 commits into from
Jun 29, 2019

Conversation

doitian
Copy link
Member

@doitian doitian commented Jun 21, 2019

  • Target Release: v0.15.0 (rylai v4)
  • Release Date: Jun 29, 2019

The default secp256k1 has changed. Now its code hash is

0x94334bdda40b69bae067d84937aa6bbccf8acd0df6626d4b9ac70d4612a11933

Highlights

Features

Bug Fixes

Improvements

xxuejie and others added 30 commits June 4, 2019 09:58
feat: add CI files for Windows environments
chore: group sentry events via fingerprint
…block

feat: add a function to select all tx-hashes from storage for a block
chore: create windows package via azure
BREAKING CHANGE: get_blockchain_info change warnings to alerts
test: add code coverage
This commit contains no CKB VM changes, it merely switch from git
commit to published CKB VM versions
@doitian doitian requested a review from a team June 21, 2019 13:23
@nervos-bot nervos-bot bot changed the title Rc/v0.15.0 [ᚬmaster] Rc/v0.15.0 Jun 21, 2019
@nervos-bot nervos-bot bot added the breaking change The feature breaks consensus, database, message schema or RPC interface. label Jun 21, 2019
@nervos-bot
Copy link

nervos-bot bot commented Jun 21, 2019

@xxuejie is assigned as the chief reviewer

@doitian
Copy link
Member Author

doitian commented Jun 21, 2019

Config files changes:

ckb-miner.toml

chain.spec

 [chain]
-spec = "specs/testnet.toml"
+spec = { file = "specs/testnet.toml" }

ckb.toml

chain.spec

 [chain]
-spec = "specs/testnet.toml"
+spec = { file = "specs/testnet.toml" }

New options network.upnp and network.discovery_local_address

 [network]
+# If set to true, try to register upnp
+upnp = false
+# If set to true, network service will add discovered local address to peer store, it's helpful for private net development
+discovery_local_address = false

New option block_assembler.data

+# Also, ckb allows the miners to add any data to the cellbase that they have dug out.
+# The data must be A 0x-prefixed hex string.
+#
+# note: The data field is optional.
+#
+# **WARNING**: if data is larger than the capacity value of the current cellbase,
+# it will be truncated
+#
+# [block_assembler]
+# code_hash = "0xf1951123466e4479842387a66fabfd6b65fc87fd84ae8e6cd3053edb27fff2fd"
+# args = [ "ckb cli blake160 <compressed-pubkey>" ]
+# data = "0x prefix hex string"

@doitian
Copy link
Member Author

doitian commented Jun 21, 2019

RPC changes:

  • Add new RPC module Indexer.
  • Response schema of get_current_epoch, get_epoch_by_number has changed.
     "result": {
-        "block_reward": "100000000000",
         "difficulty": "0x3e8",
-        "last_block_hash_in_previous_epoch": "0x0000000000000000000000000000000000000000000000000000000000000000",
+        "epoch_reward": "125000000000000",
         "length": "1250",
         "number": "0",
-        "remainder_reward": "0",
         "start_number": "0"
     }
  • Response schema of get_blockchain_info has changed
     "result": {
+        "alerts": [],
         "chain": "main",
         "difficulty": "0x3e8",
         "epoch": "0",
         "is_initial_block_download": true,
-        "median_time": "1557311762",
-        "warnings": ""
+        "median_time": "1557311762"
     }

@codecov
Copy link

codecov bot commented Jun 22, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@b4922d9). Click here to learn what that means.
The diff coverage is 68.21%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1091   +/-   ##
=========================================
  Coverage          ?   62.83%           
=========================================
  Files             ?      160           
  Lines             ?    13680           
  Branches          ?        0           
=========================================
  Hits              ?     8596           
  Misses            ?     5084           
  Partials          ?        0
Impacted Files Coverage Δ
util/test-chain-utils/src/lib.rs 100% <ø> (ø)
verification/src/transaction_verifier.rs 77.24% <ø> (ø)
util/stop-handler/src/lib.rs 63.63% <ø> (ø)
util/dao/src/lib.rs 99.05% <ø> (ø)
protocol/src/lib.rs 92.85% <ø> (ø)
verification/src/block_verifier.rs 89.53% <ø> (ø)
verification/src/uncles_verifier.rs 86.79% <ø> (ø)
core/src/extras.rs 55.81% <ø> (ø)
network/src/protocols/mod.rs 0% <ø> (ø)
verification/src/contextual_block_verifier.rs 63.72% <ø> (ø)
... and 84 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4922d9...5096207. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 22, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@b4922d9). Click here to learn what that means.
The diff coverage is 68.21%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1091   +/-   ##
=========================================
  Coverage          ?   62.83%           
=========================================
  Files             ?      160           
  Lines             ?    13680           
  Branches          ?        0           
=========================================
  Hits              ?     8596           
  Misses            ?     5084           
  Partials          ?        0
Impacted Files Coverage Δ
util/test-chain-utils/src/lib.rs 100% <ø> (ø)
verification/src/transaction_verifier.rs 77.24% <ø> (ø)
util/stop-handler/src/lib.rs 63.63% <ø> (ø)
util/dao/src/lib.rs 99.05% <ø> (ø)
protocol/src/lib.rs 92.85% <ø> (ø)
verification/src/block_verifier.rs 89.53% <ø> (ø)
verification/src/uncles_verifier.rs 86.79% <ø> (ø)
core/src/extras.rs 55.81% <ø> (ø)
network/src/protocols/mod.rs 0% <ø> (ø)
verification/src/contextual_block_verifier.rs 63.72% <ø> (ø)
... and 84 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4922d9...8f745b0. Read the comment docs.

@doitian doitian merged commit 8f745b0 into master Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change The feature breaks consensus, database, message schema or RPC interface.
Projects
None yet
Development

Successfully merging this pull request may close these issues.