Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ᚬrc/v0.14.0] fix: cellset consistency #1076

Merged

Conversation

zhangsoledad
Copy link
Member

@zhangsoledad zhangsoledad commented Jun 20, 2019

fix bug:

  • deleted full-dead cell from storage, but haven't erased it from memory.
  • should recover full-dead cell when fork occurs

@zhangsoledad zhangsoledad requested a review from a team June 20, 2019 07:54
@nervos-bot
Copy link

nervos-bot bot commented Jun 20, 2019

@quake is assigned as the chief reviewer

@zhangsoledad zhangsoledad added hotfix Fixing that must be submit to RC branch. urgent Has an upcoming deadline labels Jun 20, 2019
@zhangsoledad zhangsoledad changed the base branch from develop to rc/v0.14.0 June 20, 2019 11:01
@nervos-bot nervos-bot bot changed the title fix: cellset consistency [ᚬrc/v0.14.0] fix: cellset consistency Jun 20, 2019
Copy link
Collaborator

@yangby-cryptape yangby-cryptape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this PR do

All links in this comment are referenced to the a old commit, for showing the incorrect code.

@doitian doitian merged commit 9f6077d into nervosnetwork:rc/v0.14.0 Jun 20, 2019
This was referenced Jun 21, 2019
@zhangsoledad zhangsoledad deleted the zhangsoledad/fix_cell_set branch August 16, 2019 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix Fixing that must be submit to RC branch. urgent Has an upcoming deadline
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants