fix: resolve ChainSpec script deserialize issue
#1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TheWaWaR is assigned as the chief reviewer |
xxuejie
approved these changes
Jun 20, 2019
driftluo
approved these changes
Jun 20, 2019
doitian
approved these changes
Jun 20, 2019
yangby-cryptape
approved these changes
Jun 20, 2019
|
@nervos-bot-user try integration |
u2
reviewed
Jun 20, 2019
| @@ -237,23 +237,23 @@ impl GenesisCell { | |||
| fn build_output(&self) -> Result<CellOutput, Box<dyn Error>> { | |||
| let mut cell = CellOutput::default(); | |||
| cell.data = self.message.as_bytes().into(); | |||
| cell.lock.clone_from(&self.lock); | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
They have different types, one is core script, another is jsontypes script
quake
force-pushed
the
quake/fix-lock-args-desr
branch
from
534da31
to
5ace8ae
Compare
quake
force-pushed
the
quake/fix-lock-args-desr
branch
from
5ace8ae
to
d52fad3
Compare
This was referenced Jun 21, 2019
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.