Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ᚬrc/v0.15.z] hotfix rc0.15 #1195

Merged
merged 3 commits into from
Jul 6, 2019

Conversation

zhangsoledad
Copy link
Member

  • fix fetch invalid block
  • fix response invalid block
  • fix repeat process block overwrite block ext

@zhangsoledad zhangsoledad requested a review from a team July 5, 2019 08:46
@nervos-bot nervos-bot bot changed the title hotfix rc [ᚬrc/v0.15.z] hotfix rc Jul 5, 2019
@nervos-bot
Copy link

nervos-bot bot commented Jul 5, 2019

@driftluo is assigned as the chief reviewer

@nervos-bot nervos-bot bot added the hotfix Fixing that must be submit to RC branch. label Jul 5, 2019
@zhangsoledad zhangsoledad changed the title [ᚬrc/v0.15.z] hotfix rc [ᚬrc/v0.15.z] hotfix rc0.15 Jul 5, 2019
chain/src/chain.rs Outdated Show resolved Hide resolved
@zhangsoledad zhangsoledad force-pushed the zhangsoledad/fix_fetch_invalid_block branch 2 times, most recently from 00f8906 to 93667bc Compare July 5, 2019 11:38
Copy link
Member

@doitian doitian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a PR to develop as well

@doitian
Copy link
Member

doitian commented Jul 6, 2019

error: using '.clone()' on a ref-counted pointer
  --> chain/src/tests/basic.rs:39:24
   |
39 |         .process_block(block.clone(), true)
   |                        ^^^^^^^^^^^^^ help: try this: `Arc::<ckb_core::block::Block>::clone(&block)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_ref_ptr

@zhangsoledad zhangsoledad force-pushed the zhangsoledad/fix_fetch_invalid_block branch from 93667bc to e5afeb4 Compare July 6, 2019 06:19
@zhangsoledad zhangsoledad mentioned this pull request Jul 6, 2019
@doitian doitian merged commit 01295df into rc/v0.15.z Jul 6, 2019
@doitian doitian deleted the zhangsoledad/fix_fetch_invalid_block branch July 6, 2019 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix Fixing that must be submit to RC branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants