Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: add get_block_finalized_reward_info rpc #1297

Merged
merged 2 commits into from
Jul 25, 2019
Merged

feature: add get_block_finalized_reward_info rpc #1297

merged 2 commits into from
Jul 25, 2019

Conversation

u2
Copy link
Contributor

@u2 u2 commented Jul 24, 2019 •
edited
Loading

Firstly fix test: cellbase should have witness, otherwise the RPC test will panic.

25445bc

@u2 u2 requested a review from a team July 24, 2019 01:47
@nervos-bot
Copy link

nervos-bot bot commented Jul 24, 2019

@TheWaWaR is assigned as the chief reviewer

@u2 u2 added the s:waiting-on-reviewers Status: Waiting for Review label Jul 24, 2019
@doitian doitian added the urgent Has an upcoming deadline label Jul 25, 2019
doitian
doitian requested changes Jul 25, 2019
View reviewed changes
rpc/src/module/chain.rs Outdated Show resolved Hide resolved
rpc/json/rpc.json Outdated Show resolved Hide resolved
@doitian
Copy link
Member

doitian commented Jul 25, 2019

Suggest a new name get_cellbase_output_capacity_details

@u2 u2 requested review from doitian and TheWaWaR July 25, 2019 07:11
@u2 u2 requested a review from keroro520 July 25, 2019 09:04
keroro520
keroro520 suggested changes Jul 25, 2019
View reviewed changes
rpc/README.md Show resolved Hide resolved
@u2
Copy link
Contributor Author

u2 commented Jul 25, 2019

bors r+

@nervos-bot nervos-bot bot added the s:ready-to-merge Status: Waiting to be merged. label Jul 25, 2019
bors bot added a commit that referenced this pull request Jul 25, 2019
@bors @u2
Merge #1297
403dc91 
1297: feature: add get_block_finalized_reward_info rpc r=u2 a=u2

Firstly fix test:  `cellbase` should have `witness`, otherwise the RPC test will panic.

25445bc

Co-authored-by: u2 <zhangyaning1985@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jul 25, 2019

Build succeeded

  • continuous-integration/travis-ci/push

@bors bors bot merged commit 4469b7d into nervosnetwork:develop Jul 25, 2019
@doitian doitian mentioned this pull request Jul 25, 2019
Merged
@doitian doitian mentioned this pull request Aug 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doitian doitian doitian approved these changes

@keroro520 keroro520 keroro520 approved these changes

@xxuejie xxuejie Awaiting requested review from xxuejie

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad

@TheWaWaR TheWaWaR Awaiting requested review from TheWaWaR

Assignees

@TheWaWaR TheWaWaR

Labels
s:ready-to-merge Status: Waiting to be merged. s:waiting-on-reviewers Status: Waiting for Review urgent Has an upcoming deadline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@u2 @doitian @TheWaWaR @keroro520