Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: let sentry capture more details when failed to get_locator #1565

Merged
merged 1 commit into from
Sep 8, 2019
Merged

chore: let sentry capture more details when failed to get_locator #1565

merged 1 commit into from
Sep 8, 2019

Conversation

yangby-cryptape
Copy link
Collaborator

Sentry reported this panic in our latest release -- v0.20.0 (rylai-v9 024408e 2019-09-07) again.

@yangby-cryptape yangby-cryptape requested a review from a team September 7, 2019 12:22
@zhangsoledad
Copy link
Member

bors r=doitian,TheWaWaR

@nervos-bot nervos-bot bot added the s:ready-to-merge Status: Waiting to be merged. label Sep 8, 2019
bors bot added a commit that referenced this pull request Sep 8, 2019
@bors @yangby-cryptape
Merge #1565
6a3a4be 
1565: chore: let sentry capture more details when failed to `get_locator` r=doitian,TheWaWaR a=yangby-cryptape

Sentry reported this `panic` in our latest release -- `v0.20.0 (rylai-v9 024408e 2019-09-07)` again.

Co-authored-by: Boyu Yang <yangby@cryptape.com>
@bors
Copy link
Contributor

bors bot commented Sep 8, 2019

Build succeeded

  • continuous-integration/travis-ci/push

@bors bors bot merged commit 2168073 into nervosnetwork:develop Sep 8, 2019
@backporting backporting bot mentioned this pull request Sep 8, 2019
Merged
bors bot added a commit that referenced this pull request Sep 9, 2019
@bors @yangby-cryptape
Merge #1566
c71fa50 
1566: [ᚬrc/v0.20] [Backport rc/v0.20] chore: let sentry capture more details when failed to `get_locator` r=quake a=backporting[bot]

Backport #1565.

Co-authored-by: Boyu Yang <yangby@cryptape.com>
@yangby-cryptape yangby-cryptape deleted the pr/more-details-for-panic branch April 1, 2020 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doitian doitian doitian approved these changes

@TheWaWaR TheWaWaR TheWaWaR approved these changes

Assignees
No one assigned
Labels
s:ready-to-merge Status: Waiting to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yangby-cryptape @zhangsoledad @doitian @TheWaWaR