Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: split all unit tests into separate files #2987

Merged
merged 1 commit into from
Aug 28, 2021
Merged

test: split all unit tests into separate files #2987

merged 1 commit into from
Aug 28, 2021

Conversation

yangby-cryptape
Copy link
Collaborator

@yangby-cryptape yangby-cryptape commented Aug 27, 2021 •
edited

What problem does this PR solve?

Split all unit tests into separate files, so we can distinguish the source code more easily.

NOTICE: After this PR, all unit tests should be put into a directory named tests or a file named tests.rs.

Check List

Tests

  • Unit test

Side effects

  • Coverage of unit tests has dropped significantly:
    • Before this PR (commit: db8d371):
      • Lines: 26434 / 36061 = 73.3 %; Functions: 4596 / 9473 = 48.5 %
    • After this PR (commit: d29d633):
      • Lines: 21006 / 30477 = 68.9 %; Functions: 4102 / 8860 = 46.0 %

Release note

None: Exclude this PR from the release note.

@yangby-cryptape yangby-cryptape marked this pull request as ready for review August 27, 2021 08:28
@yangby-cryptape yangby-cryptape requested a review from a team as a code owner August 27, 2021 08:28
chanhsu001
chanhsu001 approved these changes Aug 28, 2021
View reviewed changes
Copy link
Contributor

@chanhsu001 chanhsu001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the PR works as described, thank you for your effort.

@quake
Copy link
Member

quake commented Aug 28, 2021

bors r=quake,chanhsu001

@bors
Copy link
Contributor

bors bot commented Aug 28, 2021

Build succeeded:

@bors bors bot merged commit de62c91 into nervosnetwork:develop Aug 28, 2021
@yangby-cryptape yangby-cryptape deleted the pr/split-tests branch August 30, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@chanhsu001 chanhsu001 chanhsu001 approved these changes

@doitian doitian Awaiting requested review from doitian

@driftluo driftluo Awaiting requested review from driftluo

@zhangsoledad zhangsoledad Awaiting requested review from zhangsoledad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yangby-cryptape @quake @chanhsu001