Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix dummy miner solve #3012

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Conversation

driftluo
Copy link
Collaborator

@driftluo driftluo commented Sep 7, 2021

What problem does this PR solve?

It is a mix of several problems here:

  1. Timed poll is turned on from off on dummy miner
  2. There is a consistency problem with the deletion judgment because of the background poll, that is, when self start = false, it will also update current, resulting in the previous judgment becoming false when start becomes true
  3. Poll new block template will not be updated in this case because of the same work id, i.e., it is not possible to remove the judgment error caused by 2 through poll template

The actual effect is that there is a thread in the miner that keeps on looping but does not work

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    init with dev chain, mining it, it will not be stuck

Release note

Title Only: Include only the PR title in the release note.

@driftluo driftluo requested a review from a team as a code owner September 7, 2021 03:52
@doitian
Copy link
Member

doitian commented Sep 7, 2021

bors r=doitian,yangby-cryptape

@bors
Copy link
Contributor

bors bot commented Sep 7, 2021

Build succeeded:

@bors bors bot merged commit 2202d73 into nervosnetwork:develop Sep 7, 2021
@driftluo driftluo deleted the fix-dummy-miner branch September 7, 2021 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants