Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ci_linters dose not exit 1 when command run failed #3065

Merged
merged 1 commit into from
Sep 29, 2021
Merged

fix: ci_linters dose not exit 1 when command run failed #3065

merged 1 commit into from
Sep 29, 2021

Conversation

liya2017
Copy link
Contributor

What problem does this PR solve?

ci linters failed but still exit 0

Check List

Tests

  • Unit test

Release note

None: Exclude this PR from the release note.

@liya2017 liya2017 requested a review from a team as a code owner September 29, 2021 07:50
@liya2017 liya2017 changed the title fix: fix issue that's ci_linters not exit with 1 when command fialed fix: ci_linters not exit 1 when command run failed Sep 29, 2021
@liya2017 liya2017 changed the title fix: ci_linters not exit 1 when command run failed fix: ci_linters dose not exit 1 when command run failed Sep 29, 2021
@liya2017 liya2017 force-pushed the fix_ci_linters branch 3 times, most recently from 8c333a9 to 2166bf9 Compare September 29, 2021 08:29
@quake
Copy link
Member

quake commented Sep 29, 2021

bors r=quake,chanhsu001

@bors
Copy link
Contributor

bors bot commented Sep 29, 2021

Build succeeded:

@bors bors bot merged commit 9b5c3f0 into nervosnetwork:develop Sep 29, 2021
@bors bors bot deleted the fix_ci_linters branch September 30, 2021 01:16
@yangby-cryptape yangby-cryptape mentioned this pull request Oct 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quake quake quake approved these changes

@chanhsu001 chanhsu001 chanhsu001 approved these changes

@doitian doitian Awaiting requested review from doitian

@driftluo driftluo Awaiting requested review from driftluo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liya2017 @quake @chanhsu001