docs: add documents for the data structure of Cell/Script/Transaction/Block #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keith-CY
suggested changes
Mar 5, 2019
Mine77
changed the title
Docs/add data structure
doitian
requested changes
Mar 6, 2019
… into docs/add-data-structure
u2
suggested changes
Mar 8, 2019
Co-Authored-By: Mine77 <haichaozhu77@gmail.com>
xxuejie
reviewed
Mar 8, 2019
| | `binary` | Bytes | **ELF formatted binary that contains an RISC-V based script.** This part of data is loaded into an CKB-VM instance when they are specified upon the transaction verification. | | ||
| | `reference` | Bytes | **The `type hash` of the script that is referred by this script.** It is possible to refer the script in another cell on-chain as the binary code in this script, instead of entering the binary directly into the script. **Notice:** This is part only works when the `binary` field is empty. | | ||
| | `args` | [Bytes] | **An array of arguments as the script input.** The arguments here are imported into the CKB-VM instance as input arguments for the scripts. This part is NOT used when calculating the hash of the script. | | ||
| | `signed_args` | [Bytes] | **An array of arguments that belongs to the script for improving code reuse rate**. Please refer [this document](https://github.com/Mine77/ckb-demo-ruby-sdk/blob/docs/update-docs/docs/how-to-write-contracts.md#script-model) for more explanation about this field. | |
There was a problem hiding this comment.
This sounds weird to me(improving code reuse part), but I don't have a good suggestion, any thoughts @doitian ?
There was a problem hiding this comment.
If it is weird, I would suggest just delete that part until we have a better understanding and a brief description available.
There was a problem hiding this comment.
I think it's ok to leave it this way.
At least it's just weird to you, not causing confusions.
It indeed is increasing the code reuse rate.
xxuejie
reviewed
Mar 8, 2019
doitian
approved these changes
Mar 9, 2019
u2
approved these changes
Mar 11, 2019
zhangsoledad
approved these changes
Mar 11, 2019
bors bot
added a commit
that referenced
this pull request
Feb 23, 2021
2580: chore: upgrade deps r=zhangsoledad,quake a=driftluo
futures:
```
# 0.3.12 - 2021-01-15
* Fixed `Unpin` impl of `future::{MaybeDone, TryMaybeDone}` where trait bounds were accidentally added in 0.3.9. (#2317)
# 0.3.11 - 2021-01-14
* Fixed heap buffer overflow in `AsyncReadExt::{read_to_end, read_to_string}` (#2314)
# 0.3.10 - 2021-01-13
* Fixed type-inference in `sink::unfold` by specifying more of its types (breaking change -- see #2311)
# 0.3.9 - 2021-01-08
* Significantly improved compile time when `async-await` crate feature is disabled (#2273)
* Added `stream::repeat_with` (#2279)
* Added `StreamExt::unzip` (#2263)
* Added `sink::unfold` (#2268)
* Added `SinkExt::feed` (#2155)
* Implemented `FusedFuture` for `oneshot::Receiver` (#2300)
* Implemented `Clone` for `sink::With` (#2290)
* Re-exported `MapOkOrElse`, `MapInto`, `OkInto`, `TryFlatten`, `WriteAllVectored` (#2275)
```
tentacle:
```
# Bug Fix
- Port futures-rs fix on channel(#308)
- Don't use loop on yamux(#307)
- Fix yamux close(#309)
```
Co-authored-by: driftluo <driftluo@foxmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#308
This document explains "What does each field mean?"
As for "Who is responsible to fill them?" and "How to generate them?" , I think it's more appropriate to document them it in another place, which I'm also working on in progress.
preview