Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: warn incomplete supported network protocols #3114

Merged
merged 1 commit into from
Oct 23, 2021
Merged

chore: warn incomplete supported network protocols #3114

merged 1 commit into from
Oct 23, 2021

Conversation

keroro520
Copy link
Contributor

What is changed and how it works?

What's Changed:

Added a warning log for enabling incomplete network protocols. The logs are helpful for investigating.

Related changes

Check List

Tests

  • No code (skip ci)

Release note 

None: Exclude this PR from the release note.

@keroro520 keroro520 requested review from quake, a team and driftluo and removed request for a team October 19, 2021 10:18
@keroro520 keroro520 force-pushed the warn-incompleted-supported-protocols branch from a9c90bf to 7680876 Compare October 19, 2021 11:06
@keroro520 keroro520 requested a review from a team as a code owner October 19, 2021 11:06
quake
quake previously approved these changes Oct 19, 2021
View reviewed changes
@bors bors bot changed the base branch from develop to master October 20, 2021 13:59
@bors bors bot dismissed quake’s stale review October 20, 2021 13:59

The base branch was changed.

@doitian doitian changed the base branch from master to develop October 21, 2021 00:56
@quake
Copy link
Member

quake commented Oct 23, 2021

bors r=zhangsoledad,driftluo

@bors bors bot merged commit cd65dd4 into nervosnetwork:develop Oct 23, 2021
@bors
Copy link
Contributor

bors bot commented Oct 23, 2021

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangsoledad zhangsoledad zhangsoledad approved these changes

@driftluo driftluo driftluo approved these changes

@quake quake quake left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@keroro520 @quake @zhangsoledad @driftluo