Use jsonrpc-utils to replace jsonrpc #4170
Merged
+1,110
−1,297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenyukang
requested review from
doitian,
zhangsoledad,
EthanYuan and
eval-exec
and removed request for
a team
chenyukang
force-pushed
the
use-jsonrpc-utils
branch
2 times, most recently
from
31f1266
to
ed710c6
Compare
eval-exec
approved these changes
Sep 25, 2023
chenyukang
force-pushed
the
use-jsonrpc-utils
branch
from
4d970f1
to
0e81e69
Compare
EthanYuan
reviewed
Sep 25, 2023
chenyukang
force-pushed
the
use-jsonrpc-utils
branch
2 times, most recently
from
d54a778
to
59133f7
Compare
chenyukang
force-pushed
the
use-jsonrpc-utils
branch
5 times, most recently
from
a6eafa7
to
9f63dea
Compare
chenyukang
force-pushed
the
use-jsonrpc-utils
branch
2 times, most recently
from
7bb89e9
to
ca705e3
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
zhangsoledad
approved these changes
Oct 27, 2023
|
Please rebase |
eval-exec
added
b:rpc
chenyukang
force-pushed
the
use-jsonrpc-utils
branch
from
ca705e3
to
d665457
Compare
doitian
previously requested changes
Nov 21, 2023
There was a problem hiding this comment.
Hold for testing. Waiting for the response from @gpBlockchain
chenyukang
force-pushed
the
use-jsonrpc-utils
branch
from
d665457
to
9444481
Compare
|
The codec for TCP is different. Now it is line delimited, before it does not require split JSON requests by newlines. |
chenyukang
force-pushed
the
use-jsonrpc-utils
branch
from
ec0cf75
to
2d960b9
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
We are using paritytech/jsonrpc as our RPC framework, but that project is deprecated, and currently, we have issues like #3900, #3880 need to be resolved.
In this PR, we move to
jsonrpc-utilsfor long term maintaince.Issue Number:
close #3900
close #3880
Problem Summary:
What is changed and how it works?
There are several features need to verify:
ckbAdd timeout default with 30s
What's Changed:
Related changes
owner/repoCheck List
Tests
Side effects
Release note