Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no chain_root in 1st block of the mmr activated epoch #4255

Conversation

yangby-cryptape
Copy link
Collaborator

@yangby-cryptape yangby-cryptape commented Dec 4, 2023

What problem does this PR solve?

Since CKB enabled the MMR feature through version bits with following code:

let mmr_active = self
.context
.versionbits_active(DeploymentPos::LightClient, self.parent);

versionbits.get_state(parent, cache, indexer)

the extension field of the first block in the MMR activated epoch, doesn't contain the chain root.

So, when check the extension fields, the first block in the MMR activated epoch should be skipped.

Ref: nervosnetwork/ckb-light-client#163

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Release note

Title Only: Include only the PR title in the release note.

@yangby-cryptape yangby-cryptape force-pushed the no-chain_root-in-1st-block-of-mmr-activated-epoch branch from dd0bf94 to ee78320 Compare December 4, 2023 11:17
@yangby-cryptape yangby-cryptape marked this pull request as ready for review December 4, 2023 11:49
@yangby-cryptape yangby-cryptape requested a review from a team as a code owner December 4, 2023 11:49
@yangby-cryptape yangby-cryptape requested review from doitian, quake and zhangsoledad and removed request for a team and doitian December 4, 2023 11:49
@eval-exec eval-exec added the m:light-client module: ckb-light-client label Dec 4, 2023
@zhangsoledad zhangsoledad added this pull request to the merge queue Dec 8, 2023
Merged via the queue into nervosnetwork:develop with commit 98a583d Dec 8, 2023
34 checks passed
@doitian doitian mentioned this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
m:light-client module: ckb-light-client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants