Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no chain_root in 1st block of the mmr activated epoch #4255

Merged
merged 1 commit into from
Dec 8, 2023
Merged

fix: no chain_root in 1st block of the mmr activated epoch #4255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions util/types/src/utilities/merkle_mountain_range.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,9 @@ impl VerifiableHeader {
}

/// Checks if the current verifiable header is valid.
pub fn is_valid(&self, mmr_activated_epoch: EpochNumber) -> bool {
let has_chain_root = self.header().epoch().number() >= mmr_activated_epoch;
pub fn is_valid(&self, mmr_activated_epoch_number: EpochNumber) -> bool {
let mmr_activated_epoch = EpochNumberWithFraction::new(mmr_activated_epoch_number, 0, 1);
let has_chain_root = self.header().epoch() > mmr_activated_epoch;
if has_chain_root {
if self.header().is_genesis() {
if !self.parent_chain_root().is_default() {
Expand Down
Loading