fix: resolve empty filter related message bug #4270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quake
requested review from
zhangsoledad,
yangby-cryptape and
a team
and removed request for
a team
yangby-cryptape
approved these changes
Dec 19, 2023
eval-exec
approved these changes
Dec 19, 2023
eval-exec
added
m:light-client
github-merge-queue
bot
merged commit 3e17637
into
nervosnetwork:develop
33 checks passed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
ckb full node may generate an empty filter related message and send it to light client since the filter data are built asynchronously, this may cause the light client to ban the ckb node.
What is changed and how it works?
change to use
latest_built_filter_block_numberto replace the tip number when building filter message.Check List
Tests
Release note