Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify jsonrpc types #476

Merged
merged 4 commits into from
Apr 17, 2019

Conversation

yangby-cryptape
Copy link
Collaborator

@yangby-cryptape yangby-cryptape commented Apr 15, 2019

Changes

  • chore: let all jsonrpc types be public (for client)
  • feat: change all u64 fields in RPC to String and hide internal Script struct
  • chore: replace unnecessary TryFrom by From
  • docs: fix README.md for JSON-RPC protocols

Note

pub struct CellOutputWithOutPoint {
pub out_point: OutPoint,
pub capacity: Capacity,
pub lock: Script,
}

This piece of code wasn't list for review.

But, Capacity was changed from u64 to String, and the Script was changed from ckb-core::Script to jsronrpc-tpyes::Script.

@yangby-cryptape yangby-cryptape requested a review from a team April 16, 2019 14:52
@doitian
Copy link
Member

doitian commented Apr 17, 2019

rpc/README.md is outdated, could you please update it as well. For example block number parameter in get_block_hash is still a number in the doc.

@doitian doitian added the s:waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. label Apr 17, 2019
@yangby-cryptape
Copy link
Collaborator Author

@doitian Done!

It's a bit difficult to distinguish differences between old and new versions for all protocols, so I rewrite all examples after do tests.

There are three protocols I did not write (2 for miner, 1 for test).

@quake quake merged commit 06695be into nervosnetwork:develop Apr 17, 2019
@yangby-cryptape yangby-cryptape deleted the modify-jsonrpc-types branch May 7, 2019 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants