-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎉[ᚬmaster] Rc/v0.10.0 #525
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The embedded secp256k1_blake2b_sighash_all script is compiled from https://github.com/nervosnetwork/ckb-system-scripts/blob/384da8adc0564a228f54ae4122adda12d966f9bc/c/secp256k1_blake2b_sighash_all.c
419: chore: use new constructors to make fixed structs more readable r=zhangsoledad a=yangby-cryptape Should I delete this unit test? https://github.com/nervosnetwork/ckb/blob/32be9aa704fce9c269b93b247b64e5a87dece575/util/crypto/src/secp/signature.rs#L159-L173 Co-authored-by: Boyu Yang <yangby@cryptape.com>
NOTE: This is a breaking change
418: fix: try to repair a corrupted rocksdb automatically r=quake a=yangby-cryptape I have test this patch with a corrupted database (from @TheWaWaR). But I can not reproduce the bug by myself, so I did not write any test case. The database works, but the data is still corrupted (**because `header` add new fields?**): ``` 2019-04-09 07:39:24.154 +00:00 main WARN ckb_db::diskdb Try repairing the rocksdb since Corruption: SST file is ahead of WALs ... 2019-04-09 07:39:24.384 +00:00 main WARN ckb_db::diskdb Try opening the repaired rocksdb ... thread 'main' panicked at 'header deserializing should be ok: Custom("invalid length 3, expected a 0x-prefixed hex string with 64 digits")', src/libcore/result.rs:997:5 stack backtrace: ``` Ref: - [RocksDB: Repairer](https://github.com/facebook/rocksdb/wiki/RocksDB-Repairer) - [RocksDB: WAL Recovery Modes](https://github.com/facebook/rocksdb/wiki/WAL-Recovery-Modes) - [`pub fn set_wal_recovery_mode(&mut self, mode: DBRecoveryMode)`](https://github.com/rust-rocksdb/rust-rocksdb/blob/267d92cbf9fdcbce9052ef06d7cb90b3111c6c54/src/db_options.rs#L1042-L1046) Co-authored-by: Boyu Yang <yangby@cryptape.com>
404: feat: Update embedded script r=doitian a=xxuejie The embedded secp256k1_blake2b_sighash_all script is compiled from https://github.com/nervosnetwork/ckb-system-scripts/blob/384da8adc0564a228f54ae4122adda12d966f9bc/c/secp256k1_blake2b_sighash_all.c Co-authored-by: Xuejie Xiao <xxuejie@gmail.com>
Bumps [criterion](https://github.com/bheisler/criterion.rs) from 0.2.10 to 0.2.11. - [Release notes](https://github.com/bheisler/criterion.rs/releases) - [Changelog](https://github.com/bheisler/criterion.rs/blob/master/CHANGELOG.md) - [Commits](bheisler/criterion.rs@0.2.10...0.2.11) Signed-off-by: dependabot[bot] <support@dependabot.com>
Bumps [flatbuffers-verifier](https://github.com/nervosnetwork/cfb) from 0.1.8 to 0.1.9. - [Release notes](https://github.com/nervosnetwork/cfb/releases) - [Commits](https://github.com/nervosnetwork/cfb/commits) Signed-off-by: dependabot[bot] <support@dependabot.com>
Bumps [hyper](https://github.com/hyperium/hyper) from 0.12.25 to 0.12.26. - [Release notes](https://github.com/hyperium/hyper/releases) - [Changelog](https://github.com/hyperium/hyper/blob/master/CHANGELOG.md) - [Commits](hyperium/hyper@v0.12.25...v0.12.26) Signed-off-by: dependabot[bot] <support@dependabot.com>
Bumps [regex](https://github.com/rust-lang/regex) from 1.1.4 to 1.1.5. - [Release notes](https://github.com/rust-lang/regex/releases) - [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md) - [Commits](rust-lang/regex@1.1.4...1.1.5) Signed-off-by: dependabot[bot] <support@dependabot.com>
Bumps [bincode](https://github.com/TyOverby/bincode) from 1.1.2 to 1.1.3. - [Release notes](https://github.com/TyOverby/bincode/releases) - [Commits](bincode-org/bincode@v1.1.2...v1.1.3) Signed-off-by: dependabot[bot] <support@dependabot.com>
Bumps [serde_bytes](https://github.com/serde-rs/bytes) from 0.10.5 to 0.11.1. - [Release notes](https://github.com/serde-rs/bytes/releases) - [Commits](serde-rs/bytes@0.10.5...0.11.1) Signed-off-by: dependabot[bot] <support@dependabot.com>
Bumps [serde](https://github.com/serde-rs/serde) from 1.0.89 to 1.0.90. - [Release notes](https://github.com/serde-rs/serde/releases) - [Commits](serde-rs/serde@v1.0.89...v1.0.90) Signed-off-by: dependabot[bot] <support@dependabot.com>
hotfix: fix VM hang bug for certain invalid programs
fix: several patches from testnet BREAKING CHANGE: - RPC `get_live_cell` returns `(null, "unknown")` when looking up null out point before, while returns `(null, "live")` now. --- commit 5e51d65 Author: zhangsoledad <787953403@qq.com> Date: Wed Apr 17 17:23:14 2019 +0800 fix: proposal table commit 2983480 Author: Linfeng Qian <thewawar@gmail.com> Date: Sat Apr 13 22:31:18 2019 +0800 revert: Insert repeat transaction in pool commit e74668b Author: zhangsoledad <787953403@qq.com> Date: Sat Apr 13 20:46:48 2019 +0800 fix: block download commit db31c9d Author: zhangsoledad <787953403@qq.com> Date: Sat Apr 13 18:39:00 2019 +0800 fix: conflict transaction verify
feat: add parameters to control the block generation rate in dummy mode When I do tests in my laptop, the speed of product block is too slow. Ref: #389
test: sync call rpc
…lease chore: enable overflow-checks build flag on release mode
A wrong version is selected when merged into develop from v0.9.0.
…h_all [ᚬrc/v0.10.0] fix: revert secp256k1_blake160_sighash_all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fixes
Script
#509: fix incorrect occupied capacity computation forScript
(@yangby-cryptape)send_transaction
rpc error message for unknown input or dep (@quake)valid_since
uses String instead u64 in RPC (@jjyr)local_node_info
returns duplicated addr #437: RPClocal_node_info
returns duplicated addr (@rink1969)Features
Improvements
refactor: check peers is_banned without query db #504: refactor: check peers is_banned without query db (@jjyr)
Modify jsonrpc types #476: modify jsonrpc types (@yangby-cryptape)
refactor: store module #435: refactor store module (@quake)
refactor: avoid recursive lock #392: avoid recursive lock (@zhangsoledad)
BREAKING CHANGES
get_live_cell
returns(null, "unknown")
when looking up null out point before, while returns(null, "live")
now.string
to encode all 64bit integrers now.ckb
requires config files now, useckb init
to export the default ones.