-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cellbase type script #622
Conversation
)) | ||
.build(); | ||
let block = BlockBuilder::default().transaction(cellbase).build(); | ||
let verifier = CellbaseVerifier::new(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can keep the test by using TransactionsVerifier
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@doitian it's tested in
pub fn test_capacity_outofbound() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to support the changes in #627
The cellbase used cycles should be excluded when getting transactions from pool.
Resolved, thanks. |
Please resolve conflicts |
rebased and squashed |
This PR allows the miner to set cellbase's output type, and cellbase will be verified with the same rule as a normal transaction.