refactor: remove low S check from util-crypto #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@quake is assigned as the chief reviewer |
zhangsoledad
approved these changes
Jun 3, 2019
janx
reviewed
Jun 3, 2019
janx
reviewed
Jun 3, 2019
util/crypto/src/secp/signature.rs
Outdated
| @@ -74,7 +65,7 @@ impl Signature { | |||
| return false; | |||
| } | |||
| }; | |||
| self.v() <= 1 && h_r < N && h_r >= ONE && h_s < N && h_s >= ONE | |||
| self.v() < 4 && h_r < N && h_r >= ONE && h_s < N && h_s >= ONE | |||
There was a problem hiding this comment.
After checking the source code of secp256k1 and peter wullies's answer, it seems in practice the v is only considered either 0 or 1.
I'll rollback this.
https://bitcoin.stackexchange.com/questions/38351/ecdsa-v-r-s-what-is-v
jjyr
force-pushed
the
remove-low_s-verify-from-util-crypto
branch
from
b252adf
to
468b881
Compare
janx
approved these changes
Jun 4, 2019
This was referenced Jun 21, 2019
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cause we already use witness, the low S rule for signature is unnecessary.
See https://github.com/bitcoin/bips/blob/master/bip-0062.mediawiki#new-rules