Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ᚬrc/v0.14.0] feat: Tweak consensus parameters #996

Merged
merged 3 commits into from
Jun 14, 2019
Merged

[ᚬrc/v0.14.0] feat: Tweak consensus parameters #996

merged 3 commits into from
Jun 14, 2019

Conversation

doitian
Copy link
Member

@doitian doitian commented Jun 12, 2019

  • Change target epoch duration to 4 hours
  • Reduce epoch reward to 1/4
  • Increase secondary epoch reward to 600,000 bytes

@doitian doitian requested a review from a team June 12, 2019 10:33
@nervos-bot nervos-bot bot changed the title feat: Tweak consensus parameters [ᚬrc/v0.14.0] feat: Tweak consensus parameters Jun 12, 2019
@nervos-bot
Copy link

nervos-bot bot commented Jun 12, 2019

@keroro520 is assigned as the chief reviewer

@nervos-bot nervos-bot bot added the hotfix Fixing that must be submit to RC branch. label Jun 12, 2019
@doitian doitian changed the title [ᚬrc/v0.14.0] feat: Tweak consensus parameters ✋ [ᚬrc/v0.14.0] feat: Tweak consensus parameters Jun 12, 2019
nervos-bot[bot]
nervos-bot bot previously requested changes Jun 12, 2019
Copy link

@nervos-bot nervos-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold as requested by @doitian.

@@ -4,10 +4,11 @@ name = "ckb_testnet"
version = 0
parent_hash = "0x0000000000000000000000000000000000000000000000000000000000000000"
timestamp = 1558137600000
difficulty = "0x1000"
# difficulty of the block 135599 in rylai-v2
difficulty = "0x5a7b"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will change to the last epoch of rylai-v2 before the release deadline.

spec/src/consensus.rs Outdated Show resolved Hide resolved
@zhangsoledad
Copy link
Member

/home/soledad/project/ckb/chain.rsL755
consensus.epoch_duration_target = 8 * 60 * 60 * 1000;
fix test

@doitian doitian requested a review from janx June 13, 2019 03:33
@doitian
Copy link
Member Author

doitian commented Jun 14, 2019

I'll update difficulty in another PR, so this will not be blocked.

@doitian doitian changed the title ✋ [ᚬrc/v0.14.0] feat: Tweak consensus parameters [ᚬrc/v0.14.0] feat: Tweak consensus parameters Jun 14, 2019
@nervos-bot nervos-bot bot dismissed their stale review June 14, 2019 14:14

Unhold as requested by @doitian.

@doitian doitian merged commit a4a8788 into nervosnetwork:rc/v0.14.0 Jun 14, 2019
@doitian doitian deleted the tweak-consensus-parameters branch June 14, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix Fixing that must be submit to RC branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants