Move all extended tsconfig settings to react-app #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keith-CY
approved these changes
Feb 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this might be a temporary workaround.
Reason: CRA automatically updates
tsconfig.jsonand forcesisolatedModules: trueconfig. (see facebook/create-react-app#5508)We have the react app's tsconfig extend our base sdk config, which has
"declaration": trueset. That couldn't co-exist withisolatedModules.This has resulted: 1, TypeScript would complain about the config. 2, if we remove
isolatedModulesCRA adds it back and changes the tsconfig file every time we run the app.Until we have a more elegant tsconfig setup let have all compiler options in the tsconfig.json file (some of them might be the same to default value but I didn't bother double checking them).