Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use key locker to sign neuron for windows #2913

Merged
merged 3 commits into from Oct 30, 2023
Merged

Conversation

@Keith-CY

This comment was marked as outdated.

@yanguoyu
Copy link
Collaborator

How to skip the sign if these SM_XX secrets do not exist on the fork repo?

@Keith-CY
Copy link
Collaborator Author

How to skip the sign if these SM_XX secrets do not exist on the fork repo?

Signing application failed won't block the workflow, e.g. https://github.com/nervosnetwork/neuron/actions/runs/6656736617/job/18089955073#step:13:132

@Keith-CY
Copy link
Collaborator Author

Keith-CY commented Oct 27, 2023

How to skip the sign if these SM_XX secrets do not exist on the fork repo?

It does fail if SM_API_KEY is not set because authentication is required to download the smctl executable, fixed by 0abb497

@Keith-CY Keith-CY merged commit ba66f8d into develop Oct 30, 2023
23 checks passed
@Keith-CY Keith-CY deleted the use-key-locker branch October 30, 2023 01:20
@Keith-CY Keith-CY mentioned this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants